Skip to content

sort api versions when updating clientset #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

sort api versions when updating clientset #3652

merged 1 commit into from
Mar 1, 2025

Conversation

BenTheElder
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Ensures consistent sort order across hosts.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 28, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2025
@BenTheElder
Copy link
Member Author

tested in #3646

@jpbetz jpbetz mentioned this pull request Mar 1, 2025
Merged
@BenTheElder BenTheElder mentioned this pull request Mar 1, 2025
Merged
@LiorLieberman
Copy link
Member

Thanks @BenTheElder & @jpbetz !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2025
@robscott
Copy link
Member

robscott commented Mar 1, 2025

Thanks for all the help with this @BenTheElder and @jpbetz!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 10f202e into kubernetes-sigs:main Mar 1, 2025
12 of 13 checks passed
@BenTheElder BenTheElder deleted the sort branch March 1, 2025 00:48
@BenTheElder BenTheElder mentioned this pull request Mar 6, 2025
Merged
@BenTheElder
Copy link
Member Author

BenTheElder commented Mar 11, 2025 •
edited
Loading

This should be unnecessary next time client-gen is upgraded kubernetes/kubernetes#130626

@robscott
Copy link
Member

Thanks @BenTheElder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @LiorLieberman @robscott @k8s-ci-robot