Skip to content

Support attaching ListenerSets across namespaces #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 27, 2025
Merged

Support attaching ListenerSets across namespaces #3632

merged 6 commits into from
Feb 27, 2025

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Feb 25, 2025 •
edited
Loading

This builds on top of #3588 to add support for attaching across namespaces

Part of #1713

Release Note

Allows ListenerSets to attach to Gateways in other namespaces

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 25, 2025
@dprotaso
Copy link
Contributor Author

/hold

@dprotaso dprotaso mentioned this pull request Feb 25, 2025
Merged
youngnick
youngnick reviewed Feb 26, 2025
View reviewed changes
@dprotaso dprotaso force-pushed the listenerset-multi-namespace branch from e42ef96 to ffe6adb Compare February 26, 2025 18:36
@dprotaso dprotaso force-pushed the listenerset-multi-namespace branch from ffe6adb to fcbcb47 Compare February 26, 2025 18:48
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 26, 2025
@dprotaso
Copy link
Contributor Author

Ok rebased and updated the GEP slightly.

@dprotaso
Copy link
Contributor Author

cc @robscott @kflynn @shaneutt @youngnick @mlavacca

@shaneutt shaneutt added this to the v1.3.0 milestone Feb 26, 2025
@shaneutt shaneutt moved this to Review in Gateway API Pipeline Feb 26, 2025
shaneutt
shaneutt reviewed Feb 26, 2025
View reviewed changes
@dprotaso @shaneutt
Update gateway_types.go
1ce5934 
Co-authored-by: Shane Utt <[email protected]>
robscott
robscott approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dprotaso!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@youngnick
Copy link
Contributor

Aside from those last small things, this LGTM for Experimental.

@dprotaso dprotaso mentioned this pull request Feb 27, 2025
Merged
robscott
robscott approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dprotaso!

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d851d24 into kubernetes-sigs:main Feb 27, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Gateway API Pipeline Feb 27, 2025
@dprotaso dprotaso deleted the listenerset-multi-namespace branch February 27, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt left review comments

@youngnick youngnick youngnick left review comments

@robscott robscott robscott approved these changes

@gcs278 gcs278 Awaiting requested review from gcs278

@mlavacca mlavacca Awaiting requested review from mlavacca

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Gateway API Pipeline
Status: Done
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dprotaso @youngnick @k8s-ci-robot @robscott @shaneutt