-
Notifications
You must be signed in to change notification settings - Fork 567
fix(grpcroute-doc): fix grpcroute structure definition error in the document #3344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @0xff-dev! |
Hi @0xff-dev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…ocument Signed-off-by: 0xff-dev <[email protected]>
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/approve
/lgtm
There's actually a couple places I see where examples are still using values instead of a list. I'll do a follow up PR to clean those up, appreciate you spotting and fixing this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xff-dev, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ocument (kubernetes-sigs#3344) Signed-off-by: 0xff-dev <[email protected]>
What type of PR is this?
/kind documentation
What this PR does / why we need it:
According to the definition of grpcroute v1, the
matches[index].headers
structure in the document is incorrectly defined.In addition, should the structure definition here be adjusted to:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: