-
Notifications
You must be signed in to change notification settings - Fork 585
Conformance tweaks for Linkerd and other meshes #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance tweaks for Linkerd and other meshes #2312
Conversation
Signed-off-by: [email protected]
Signed-off-by: [email protected]
… Gateways Signed-off-by: [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; will wait for a bit for john to have a look
…into ParseKeyValuePairs Signed-off-by: [email protected]
Thanks @kflynn! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, keithmattix, kflynn, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug
/area conformance
This PR makes some small changes to allow conformance to work for Linkerd and, most likely, other meshes that don't also provide gateway controllers. Huge props to @adleong for doing most of the heavy lifting on this, weeks ago. 🙂
Like most nontrivial PRs of mine, it is best reviewed commit by commit.
Allow
-namespace-annotations
to annotate namespaces created by the testsWe already had
-namespace-labels
to supply labels on test namespaces. Linkerd needs annotations rather than labels, so we add a new parallel flag to set annotations on test namespaces.Document
-namespace-annotations
Documentation is in a separate commit.
comment fix
This just triggered me so I had to fix it. 🙂
Split out
MeshNamespacesMustBeReady
, since mesh namespaces don't have GatewaysIf testing a service mesh that doesn't also provide a gateway controller, there won't be any Gateways in the namespace, so this pulls out a separate function to check that the namespace is ready without needing Gateways, and uses it for the namespaces used for mesh testing.
MeshFrontendHostname
requiresHTTPResponseHeaderModification
The
MeshFrontendHostname
test actually relies on a header modification, but wasn't tagged as such.Does this PR introduce a user-facing change?: