Skip to content

Conversation

kflynn
Copy link
Contributor

@kflynn kflynn commented Aug 16, 2023

/kind bug
/area conformance

This PR makes some small changes to allow conformance to work for Linkerd and, most likely, other meshes that don't also provide gateway controllers. Huge props to @adleong for doing most of the heavy lifting on this, weeks ago. 🙂

Like most nontrivial PRs of mine, it is best reviewed commit by commit.

  • Allow -namespace-annotations to annotate namespaces created by the tests

    We already had -namespace-labels to supply labels on test namespaces. Linkerd needs annotations rather than labels, so we add a new parallel flag to set annotations on test namespaces.

  • Document -namespace-annotations

    Documentation is in a separate commit.

  • comment fix

    This just triggered me so I had to fix it. 🙂

  • Split out MeshNamespacesMustBeReady, since mesh namespaces don't have Gateways

    If testing a service mesh that doesn't also provide a gateway controller, there won't be any Gateways in the namespace, so this pulls out a separate function to check that the namespace is ready without needing Gateways, and uses it for the namespaces used for mesh testing.

  • MeshFrontendHostname requires HTTPResponseHeaderModification

    The MeshFrontendHostname test actually relies on a header modification, but wasn't tagged as such.

Does this PR introduce a user-facing change?:

Better support mesh-only conformance testing

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2023
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; will wait for a bit for john to have a look

@robscott
Copy link
Member

Thanks @kflynn!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, keithmattix, kflynn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit d8978a7 into kubernetes-sigs:main Aug 16, 2023
@kflynn kflynn deleted the flynn/linkerd-conformance branch August 16, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants