Skip to content

Define how to reflect partial validity of routing rules in the HTTPRoute status #1696

@pleshakov

Description

@pleshakov

What would you like to be added:

If we have an HTTPRoute resource with some if its routing rules valid, some -- not valid (for example, PathMatchType in HTTPPathMatch is not one of Exact;PathPrefix;RegularExpression), define how to report that in the HTTPRoute status.

Why this is needed:

Current documentation is a bit contradictory:

The HTTPRoute docs say:

	// Unknown values here must result in the implementation setting the
	// Accepted Condition for the Route to `status: False`, with a
	// Reason of `UnsupportedValue`.

However, in GEP-1364, it is mentioned:

HTTPRoute with two rules, one valid and one which specifies a HTTPRequestRedirect filter _and a HTTPURLRewrite filter. Accepted is true, because the valid rule can produce some config in the data plane. We'll need to raise the more specific error condition for an incompatible filter combination as well to make the partial validity clear.

This comes from #1674 and a discussion on Kubernetes Gateway API Slack sig-network-gateway-api https://kubernetes.slack.com/archives/CR0H13KGA/p1675122817360569

Metadata

Metadata

Assignees

Labels

kind/featureCategorizes issue or PR as related to a new feature.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.release-blockerMUST be completed to complete the milestone

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions