generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 565
Closed
Labels
area/conformance-testIssues or PRs related to Conformance tests.Issues or PRs related to Conformance tests.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.release-blockerMUST be completed to complete the milestoneMUST be completed to complete the milestone
Milestone
Description
What would you like to be added:
In the Gateway
conformance tests, the ListenerConditionResolvedRefs
is checked only in those tests expecting it to have statusfalse
(e.g., GatewaySecretMissingReferenceGrant
, GatewaySecretInvalidReferenceGrant
, ...), but it is never checked in those tests who expect the routing to be successful. This leads to never checking the ResolvedRefs
reason with ConditionStatus == true
.
Why this is needed:
This is needed to ensure that the ListenerConditionResolvedRefs
is always set, no matter if the ConditionStatus
is true
, or false
.
robscott, youngnick, shaneutt and mikemorris
Metadata
Metadata
Assignees
Labels
area/conformance-testIssues or PRs related to Conformance tests.Issues or PRs related to Conformance tests.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.release-blockerMUST be completed to complete the milestoneMUST be completed to complete the milestone