Make ginkgo less verbose #1984
Merged
Make ginkgo less verbose #1984
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix a regression in CI causing the error:
```
panic: runtime error: index out of range [1] with length 1
goroutine 111 [running]:
github.com/onsi/ginkgo/v2/reporters.(*DefaultReporter).codeLocationBlock(_, {{0xc00025aa40, 0x2, 0x2}, {0xc0001ec460, 0x2, 0x2}, {0xc0004ca540, 0x2, 0x2}, ...}, ...)
/home/runner/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/reporters/default_reporter.go:798 +0x2cb0
github.com/onsi/ginkgo/v2/reporters.(*DefaultReporter).DidRun(_, {{0xc00025aa40, 0x2, 0x2}, {0xc0001ec460, 0x2, 0x2}, {0xc0004ca540, 0x2, 0x2}, ...})
/home/runner/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/reporters/default_reporter.go:325 +0x12d5
github.com/onsi/ginkgo/v2/internal/parallel_support.(*ServerHandler).SpecSuiteWillBegin(_, {{0xc00002caf8, 0x17}, {0xc0001eb1b0, 0xe}, {0x0, 0x0, 0x0}, {0x0, 0x0, ...}, ...}, ...)
/home/runner/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/internal/parallel_support/server_handler.go:65 +0x1df
reflect.Value.call({0xc00028e5a0?, 0xc000288190?, 0x13?}, {0xad016a, 0x4}, {0xc000273ef8, 0x3, 0x3?})
/opt/hostedtoolcache/go/1.25.0/x64/src/reflect/value.go:581 +0xcc6
reflect.Value.Call({0xc00028e5a0?, 0xc000288190?, 0x41df74?}, {0xc000059ef8?, 0x0?, 0x0?})
/opt/hostedtoolcache/go/1.25.0/x64/src/reflect/value.go:365 +0xb9
net/rpc.(*service).call(0xc000290180, 0xc0002aa050, 0xc0001eab50, 0xc0001eab60, 0xc000282a00, 0xc0003fa020, {0xab8400?, 0xc0000e8800?, 0x893b45?}, {0x9eb8e0, ...}, ...)
/opt/hostedtoolcache/go/1.25.0/x64/src/net/rpc/server.go:383 +0x209
created by net/rpc.(*Server).ServeCodec in goroutine 102
/opt/hostedtoolcache/go/1.25.0/x64/src/net/rpc/server.go:480 +0x3de
```
Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This should fix a regression in CI causing the error:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?