Responding to comments on #137 #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Brown <[email protected]>
k8s-ci-robot
added
size/L
Signed-off-by: Mike Brown <[email protected]>
mikebrow
force-pushed
the
docker-default-context
branch
from
4f0e801 to
6a276b2
Compare
Contributor
Author
|
@Random-Liu per discussion I also removed the two unconfined cases with no additional caps set that were relying on the default caps currently set by docker and containerd. As discussed we can test out default caps over in a cri-containerd bucket and leave this un-tested for now since the default caps are not specified (currently) in CRI. |
Contributor
Thanks! :) |
Contributor
|
LGTM |
Random-Liu
added
the
lgtm
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments from @Random-Liu on #137.
Signed-off-by: Mike Brown [email protected]