-
Notifications
You must be signed in to change notification settings - Fork 623
✨ Allocate dedicated host when a dedicated host doesn't exist #5631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Allocate dedicated host when a dedicated host doesn't exist #5631
Conversation
Skipping CI for Draft Pull Request. |
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0cadb9a
to
2dd765e
Compare
Hi @rvanderp3, |
not at all, I appreciate the early feedback |
2dd765e
to
92e2a20
Compare
covers #5599 |
@rvanderp3 thanks! this is looking great. I dropped some early feedback. |
e9dc543
to
c46e590
Compare
b7663d0
to
881dd09
Compare
881dd09
to
26d49bf
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a58c1d0
to
bdb33da
Compare
/hold investigating test failures |
Co-authored-by: Jim Zimmerman <[email protected]>
bdb33da
to
55b4aca
Compare
@rvanderp3: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
after conferring with my team, it sounds like the apidiff error may be expected due to changes to the API. dropping the hold and ready for review. |
/unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Builds on #5548 to enable CAPA to allocate a dedicated host. This removes the requirement that a dedicated host exist prior to instance provisioning. A core assumption of this PR is that there is a 1:1 mapping between an instance and the dedicated host on which it runs. Nothing in this implementation precludes scheduling multiple instances to a given dedicated host, but that is not the goal of this initial implementation.
Special notes for your reviewer:
Checklist:
Release note:
Adds support for provisioning an instance on a new dedicated host.