Skip to content

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Aug 26, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Builds on #5548 to enable CAPA to allocate a dedicated host. This removes the requirement that a dedicated host exist prior to instance provisioning. A core assumption of this PR is that there is a 1:1 mapping between an instance and the dedicated host on which it runs. Nothing in this implementation precludes scheduling multiple instances to a given dedicated host, but that is not the goal of this initial implementation.

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes emoji in title
  • adds unit tests

Release note:

Adds support for provisioning an instance on a new dedicated host.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 26, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from 0cadb9a to 2dd765e Compare August 27, 2025 13:54
@punkwalker
Copy link
Contributor

punkwalker commented Aug 27, 2025

Hi @rvanderp3,
Thank you for picking this up.
I know the PR is still in draft but I wanted to add some suggestion at the start. Hope you don't mind.

@rvanderp3
Copy link
Contributor Author

Hi @rvanderp3, Thank you for picking this up. I know the PR is still in draft but I wanted to add some suggestion at the start. Hope you don't mind.

not at all, I appreciate the early feedback

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from 2dd765e to 92e2a20 Compare August 27, 2025 20:31
@enxebre
Copy link
Member

enxebre commented Aug 28, 2025

covers #5599

@enxebre
Copy link
Member

enxebre commented Aug 28, 2025

@rvanderp3 thanks! this is looking great. I dropped some early feedback.

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from e9dc543 to c46e590 Compare August 28, 2025 20:21
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 6 times, most recently from b7663d0 to 881dd09 Compare September 4, 2025 19:49
@damdo
Copy link
Member

damdo commented Sep 5, 2025

/assign @damdo @nrb

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from 881dd09 to 26d49bf Compare September 5, 2025 13:49
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nrb. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 4 times, most recently from a58c1d0 to bdb33da Compare September 5, 2025 16:09
@rvanderp3 rvanderp3 marked this pull request as ready for review September 5, 2025 16:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot requested a review from faiq September 5, 2025 16:16
@rvanderp3
Copy link
Contributor Author

/hold

investigating test failures

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from bdb33da to 55b4aca Compare September 5, 2025 19:41
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 5, 2025

@rvanderp3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-apidiff-main 55b4aca link false /test pull-cluster-api-provider-aws-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rvanderp3
Copy link
Contributor Author

after conferring with my team, it sounds like the apidiff error may be expected due to changes to the API. dropping the hold and ready for review.

@rvanderp3
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants