Skip to content

Add connection_duration_seconds histogram for post-dial connection lifespan - #899

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
HarnageaGabriel:add-connection-lifespan-metric
Aug 19, 2026
Merged

Add connection_duration_seconds histogram for post-dial connection lifespan#899
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
HarnageaGabriel:add-connection-lifespan-metric

Conversation

@HarnageaGabriel

Copy link
Copy Markdown
Contributor

Summary

  • Adds a connection_duration_seconds Prometheus histogram (buckets 1s–24h) tracking how long a proxied end-to-end connection stays established (post-dial) before it closes.
  • Records the establish timestamp on ProxyClientConnection and observes the duration on both removal paths (removeEstablished, removeEstablishedForBackendConn), mirroring the existing dial_failure_count/reason instrumentation style.

Addresses one item of the checklist in #410 ("Connection lifespan (histogram)").

Test plan

  • go build ./...
  • go test ./pkg/server/... (68 tests pass, includes new TestConnectionDurationMetric)

🤖 Generated with Claude Code

…fespan

Operators lack visibility into how long proxied connections stay open
end-to-end once established, making it hard to reason about connection
churn or spot abnormally short-lived sessions. Track the established
timestamp on ProxyClientConnection and observe the elapsed duration on
every removal path (normal close and backend-conn cleanup), mirroring
the existing dial_failure_count/reason instrumentation pattern.

Addresses one item of the checklist in
kubernetes-sigs#410.
@kubernetes-prow
kubernetes-prow Bot requested review from elmiko and ipochi August 11, 2026 16:53
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @HarnageaGabriel!

It looks like this is your first PR to kubernetes-sigs/apiserver-network-proxy 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/apiserver-network-proxy has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 11, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @HarnageaGabriel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2026
@cheftako

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2026
@cheftako

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, HarnageaGabriel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit be753a4 into kubernetes-sigs:master Aug 19, 2026
22 checks passed
@HarnageaGabriel
HarnageaGabriel deleted the add-connection-lifespan-metric branch August 19, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants