Skip to content

Add Apache 2.0 license to the client module #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jul 21, 2021
Merged

Add Apache 2.0 license to the client module #166

k8s-ci-robot merged 1 commit into from
Jul 21, 2021

Conversation

@mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Jul 21, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:

Adds the missing LICENSE file in the client module.

Does this PR introduce a user-facing change?:

Added a LICENSE file in the client csi-proxy module

/cc @jingxu97 @ddebroy

@k8s-ci-robot k8s-ci-robot requested review from ddebroy and jingxu97 July 21, 2021 20:18
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2021
ddebroy
ddebroy approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5175ec3 into kubernetes-csi:master Jul 21, 2021
@mauriciopoppe mauriciopoppe mentioned this pull request Jul 21, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 22, 2021
@k8s-ci-robot
Merge pull request #167 from mauriciopoppe/automated-cherry-pick-of-#…
24a2fcc 
…166-upstream-release-1.0

Automated cherry pick of #166: Add Apache 2.0 license to the client module
@mauriciopoppe mauriciopoppe mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

1 more reviewer

@ddebroy ddebroy ddebroy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ddebroy ddebroy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mauriciopoppe @k8s-ci-robot @ddebroy