Skip to content

Migrate deprecated Bucket4J class usage to Bucket class to unblock upgrades #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

danielburrell
Copy link
Contributor

Migrate deprecated Bucket4J class usage to Bucket class to unblock upgrades

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2024
@danielburrell danielburrell mentioned this pull request Jul 29, 2024
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, danielburrell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@brendandburns
Copy link
Contributor

fwiw, I'm ok to merge this PR, but in the future, the commits that are cherry-picked should come in as owned by the original author, not by you.

@k8s-ci-robot k8s-ci-robot merged commit 4a706d6 into kubernetes-client:release-21 Jul 29, 2024
16 checks passed
@danielburrell
Copy link
Contributor Author

danielburrell commented Jul 29, 2024

@brendandburns Thanks for the merge!, If you have a moment, could you clarify please? I know the 'issue' raised to release came from my work account daniel-b2c2 but the original author on master was this account I'm typing from (danielburrell), and the cherry-pick was done from the same account (danielburrell) - so they do match. Do let me know if I've misunderstood?

fyi I used:

git add remote -f kubernetes-client https://github.com/kubernetes-client/java
git checkout release-21
# three cherry picks
git cherry-pick d002f42
git cherry-pick 517f7a6
git cherry-pick 6596e9a
# merge conflict resolved
git cherry-pick --continue 
git push origin release-21

@brendandburns
Copy link
Contributor

oh, ok, apologies, I was confused. I think I forgot that you did the original changes, I expected the version bump to come from dependabot.

Thanks for checking (and for the PR!)

@daniel-b2c2
Copy link

Awesome, thanks for your guidance 👍 (and the release!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants