-
Notifications
You must be signed in to change notification settings - Fork 2k
Migrate deprecated Bucket4J class usage to Bucket class to unblock upgrades #3601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate deprecated Bucket4J class usage to Bucket class to unblock upgrades #3601
Conversation
The groupId com.github.vladimir-bukhtoyarov has migrated to com.bucket4j see https://mvnrepository.com/artifact/com.github.vladimir-bukhtoyarov/bucket4j-core/8.0.1
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, danielburrell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fwiw, I'm ok to merge this PR, but in the future, the commits that are cherry-picked should come in as owned by the original author, not by you. |
@brendandburns Thanks for the merge!, If you have a moment, could you clarify please? I know the 'issue' raised to release came from my work account fyi I used:
|
oh, ok, apologies, I was confused. I think I forgot that you did the original changes, I expected the version bump to come from dependabot. Thanks for checking (and for the PR!) |
Awesome, thanks for your guidance 👍 (and the release!) |
Migrate deprecated Bucket4J class usage to Bucket class to unblock upgrades