Skip to content

Fix arrayIndexOutOfBounds exception for overloaded addModelMap method #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2021
+8 −2
Merged

Fix arrayIndexOutOfBounds exception for overloaded addModelMap method #2046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions util/src/main/java/io/kubernetes/client/util/ModelMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,11 @@ public class ModelMapper {
@Deprecated
public static void addModelMap(String apiGroupVersion, String kind, Class<?> clazz) {
String[] parts = apiGroupVersion.split("/");
if (parts.length == 1) { // legacy api group
if (parts.length <= 1) { // legacy api group
addModelMap("", apiGroupVersion, kind, clazz);
} else {
addModelMap(parts[0], parts[1], kind, clazz);
}
addModelMap(parts[0], parts[1], kind, clazz);
}

/**
Expand Down
5 changes: 5 additions & 0 deletions util/src/test/java/io/kubernetes/client/util/ModelMapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ public void testAddingModel() {

assertNull(ModelMapper.getApiTypeClass("example.io/v1", "Tofu"));
assertNull(ModelMapper.getApiTypeClass("example.io", "v1", "Tofu"));

assertNull(ModelMapper.getApiTypeClass("v1", "Togu"));
ModelMapper.addModelMap("v1", "Togu", objClass);
assertEquals(objClass, ModelMapper.getApiTypeClass("", "v1", "Togu"));
assertEquals(objClass, ModelMapper.getApiTypeClass("v1", "Togu"));
}

@Test
Expand Down