Skip to content

ci: post PR E2E checks with subprocess.run - #7280

Merged
zhangzujian merged 1 commit into
kubeovn:masterfrom
zhangzujian:fix/e2e-pr-check-run-input
Aug 20, 2026
Merged

ci: post PR E2E checks with subprocess.run#7280
zhangzujian merged 1 commit into
kubeovn:masterfrom
zhangzujian:fix/e2e-pr-check-run-input

Conversation

@zhangzujian

Copy link
Copy Markdown
Member

The trusted executor on #7275 failed in Publish x86 E2E checks on the pull request:

https://github.com/kubeovn/kube-ovn/actions/runs/32357660234/job/96390358290

TypeError: Popen.__init__() got an unexpected keyword argument 'input'

subprocess.check_call forwards kwargs to Popen, which has no input. That path was previously skipped because no selected jobs existed yet. After queued placeholders landed, the first upsert crashed and PR HEAD checks stayed empty.

Use subprocess.run(..., input=..., check=True) for POST/PATCH.

Signed-off-by: Zujian Zhang zhangzujian.7@gmail.com

The reporter used subprocess.check_call(..., input=...), which Popen
rejects. Placeholders made that path run immediately, so the publisher
exited before creating any pull request checks.

Signed-off-by: Zujian Zhang <zhangzujian.7@gmail.com>
@zhangzujian
zhangzujian requested a review from oilbeater as a code owner August 20, 2026 10:32
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. ci github_actions Pull requests that update GitHub Actions code labels Aug 20, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32359406409

Coverage decreased (-0.007%) to 32.744%

Details

  • Coverage decreased (-0.007%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 4 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

4 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
pkg/bfddsupervisor/socket.go 2 51.58%
pkg/ovs/ovn-nb-bfd.go 2 61.61%

Coverage Stats

Coverage Status
Relevant Lines: 64588
Covered Lines: 21149
Line Coverage: 32.74%
Coverage Strength: 0.38 hits per line

💛 - Coveralls

@zhangzujian
zhangzujian merged commit c9df9cb into kubeovn:master Aug 20, 2026
36 of 37 checks passed
@zhangzujian
zhangzujian deleted the fix/e2e-pr-check-run-input branch August 20, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci github_actions Pull requests that update GitHub Actions code size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants