fix(ci): accept isolated executor refs in x86 E2E selection - #7254
Merged
zhangzujian merged 1 commit intoAug 19, 2026
Merged
Conversation
Automatic dispatch creates a disposable x86-e2e/pr-* ref that points at the PR base SHA. Selection compared GITHUB_REF_NAME to the base branch name, so every isolated executor failed before running smoke. Signed-off-by: Zujian Zhang <zhangzujian.7@gmail.com>
dosubot
Bot
added
size:XS
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
#7253 unblocked creating the disposable automatic executor ref. The
executor then failed immediately in
x86 E2E Selection:Selection compared
GITHUB_REF_NAMEtopull_request.base.ref. Isolatedexecutor refs are named
x86-e2e/pr-<n>-a-<approval>-d-<generation>andonly point at the base SHA, so that check can never succeed for the
intended dispatch path.
This keeps the SHA == base check, and accepts either the real base branch
or the exact isolated executor ref for that approval/dispatch generation.
Evidence from the first post-hotfix executor:
x86-e2e/pr-7251-a-1-d-32235889723atf8b3c711fUntil this lands on
master,workflow_dispatchstill loads the oldselector from the isolated ref, so this PR's own automatic executor will
keep failing that check.
Which issue(s) this PR fixes
Follow-up to #7253 / #7244. Related to #7230.
Special notes for reviewers
hack/test_e2e_control.pynow covers the exact isolated ref from PR #7251generation
32235889723.