Skip to content

Provide tutorial for OIDC Authentication with AWS ALB on Kubeflow#1780

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:yao_aws_account
Mar 12, 2020
Merged

Provide tutorial for OIDC Authentication with AWS ALB on Kubeflow#1780
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:yao_aws_account

Conversation

@PatrickXYS

@PatrickXYS PatrickXYS commented Mar 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #1672

Description of your changes:
We've already provided a Cognito Authentication tutorial for our users, but some of aws users want to use OIDC with ALB for authentication. Thus, we provide a tutorial of setting up OIDC authentication with Github Login with ALB on Kubeflow.

This change is Reviewable

@PatrickXYS

PatrickXYS commented Mar 6, 2020

Copy link
Copy Markdown
Member Author

/WIP

@k8s-ci-robot

k8s-ci-robot commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

Hi @PatrickXYS. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS

PatrickXYS commented Mar 6, 2020

Copy link
Copy Markdown
Member Author

/assign @Jeffwan

@PatrickXYS

PatrickXYS commented Mar 6, 2020

Copy link
Copy Markdown
Member Author

It's still under development. The reason I want to create the PR is keeping you updated. @Jeffwan

@PatrickXYS PatrickXYS force-pushed the yao_aws_account branch 3 times, most recently from e8288fb to 114ad3d Compare March 6, 2020 21:32
@PatrickXYS PatrickXYS changed the title WIP: Provide OIDC Github Login with ALB on Kubeflow Provide OIDC Github Login with ALB on Kubeflow Mar 6, 2020
@PatrickXYS PatrickXYS changed the title Provide OIDC Github Login with ALB on Kubeflow Provide tutorial for OIDC Authentication with ALB on Kubeflow Mar 6, 2020
@PatrickXYS PatrickXYS force-pushed the yao_aws_account branch 3 times, most recently from 9aab43c to c2f3ec0 Compare March 6, 2020 23:17
@PatrickXYS PatrickXYS changed the title Provide tutorial for OIDC Authentication with ALB on Kubeflow Provide tutorial for OIDC Authentication with AWS ALB on Kubeflow Mar 7, 2020
Jeffwan
Jeffwan reviewed Mar 8, 2020
View reviewed changes
Comment thread content/docs/aws/authentication-oidc.md Outdated
Jeffwan
Jeffwan suggested changes Mar 8, 2020
View reviewed changes
Comment thread content/docs/aws/authentication-oidc.md Outdated
Comment thread content/docs/aws/authentication-oidc.md
@PatrickXYS

PatrickXYS commented Mar 9, 2020

Copy link
Copy Markdown
Member Author

/WIP

@PatrickXYS PatrickXYS changed the title Provide tutorial for OIDC Authentication with AWS ALB on Kubeflow WIP: Provide tutorial for OIDC Authentication with AWS ALB on Kubeflow Mar 9, 2020
@Jeffwan

Jeffwan commented Mar 9, 2020

Copy link
Copy Markdown
Member

@PatrickXYS You can use WIP in the PR title in the future, I don't suggest you use it in commit log, and also make some other commits meaningful. One example is the new commit Fix issue.

@PatrickXYS

PatrickXYS commented Mar 9, 2020

Copy link
Copy Markdown
Member Author

@Jeffwan Thank you for your suggestion, and for new added commit, they exist temporarily and I'll squash them after finished development. And I'll make new commit more meaningful.

@PatrickXYS PatrickXYS force-pushed the yao_aws_account branch 2 times, most recently from 7fffd67 to a482425 Compare March 10, 2020 18:45
@PatrickXYS PatrickXYS changed the title WIP: Provide tutorial for OIDC Authentication with AWS ALB on Kubeflow Provide tutorial for OIDC Authentication with AWS ALB on Kubeflow Mar 10, 2020
@PatrickXYS PatrickXYS force-pushed the yao_aws_account branch 3 times, most recently from 14e2be1 to 696caa9 Compare March 10, 2020 22:34
@Jeffwan

Jeffwan commented Mar 10, 2020

Copy link
Copy Markdown
Member

/cc @sarahmaddox

@Jeffwan

Jeffwan commented Mar 10, 2020

Copy link
Copy Markdown
Member

/ok-to-test

@Jeffwan

Jeffwan commented Mar 12, 2020

Copy link
Copy Markdown
Member

It looks good to me on the technical side.

/lgtm

@sarahmaddox

sarahmaddox commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

Preview: https://deploy-preview-1780--competent-brattain-de2d6d.netlify.com/docs/aws/authentication-oidc/

/assign

sarahmaddox
sarahmaddox suggested changes Mar 12, 2020
View reviewed changes

@sarahmaddox sarahmaddox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickXYS I've added a couple of comments about using shortcodes (variables) and relative URLs.

Comment thread content/docs/aws/authentication-oidc.md Outdated
Comment thread content/docs/aws/authentication-oidc.md Outdated
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 12, 2020
@PatrickXYS

PatrickXYS commented Mar 12, 2020

Copy link
Copy Markdown
Member Author

Preview: https://5e6ac7630f252a0008e6691a--competent-brattain-de2d6d.netlify.com/

@sarahmaddox In the latest commit, I addressed your comments and you could check the preview. Thank you for guidance!

@sarahmaddox

sarahmaddox commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

Thanks @PatrickXYS!
/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d3a6ab6 into kubeflow:master Mar 12, 2020
@PatrickXYS PatrickXYS deleted the yao_aws_account branch March 12, 2020 23:42
This was referenced Apr 10, 2020
Closed
Merged
aronchick pushed a commit to aronchick/website-2 that referenced this pull request Feb 19, 2026
@PatrickXYS
Provide OIDC Github Login with AWS on Kubeflow (kubeflow#1780)
210c0e4
aronchick pushed a commit to aronchick/website-2 that referenced this pull request Feb 19, 2026
@PatrickXYS
Provide OIDC Github Login with AWS on Kubeflow (kubeflow#1780)
e396dfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@thedriftofwords thedriftofwords Awaiting requested review from thedriftofwords

2 more reviewers

@sarahmaddox sarahmaddox sarahmaddox requested changes

@Jeffwan Jeffwan Jeffwan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Jeffwan Jeffwan

@sarahmaddox sarahmaddox

Labels

approved lgtm ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[AWS] OIDC authentication example

4 participants

@PatrickXYS @k8s-ci-robot @Jeffwan @sarahmaddox