Splat recordExecutorEvent args for cleaner event messages

[matschaffer-roblox]

PR loosely related to #1263

Purpose of this PR

Splats args provided to recordExecutorEvent to avoid missing interpolation in event messages.

Change Category

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Rationale

Without this change you'll get messages that look like this:

Executor [spark-pi-python-oomer-9ee50397e27f13ad-exec-3 %!s(int32=137) OOMKilled] failed with ExitCode: %!d(MISSING), Reason: %!s(MISSING)

With this change they look like this instead:

Executor spark-pi-python-oomer-47432597e2cf7545-exec-3 failed with ExitCode: 137, Reason: OOMKilled

Checklist

• I have conducted a self-review of my own code.
• I have updated documentation accordingly. no documentation found on event formatting
• I have added tests that prove my changes are effective or that my feature works. see Additional Notes
• Existing unit tests pass locally with my changes.

Additional Notes

It looks like the args slice was introduced back in #1280 and has been un-splatted ever since.

There doesn't appear to be any specific testing for these event recorders, but I confirmed via panic insertion that it does get exercised by "SparkApplication Controller When reconciling a running SparkApplication [It] Should add the executors to the SparkApplication"

[ChenYi015]

@matschaffer-roblox Thanks for fixing the executor event recorder format issue.
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ChenYi015]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matschaffer-roblox]

Thanks for the quick merge @ChenYi015 !