Use code-generator for clientset, informers, listers #2563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
jbhalodia-slack
changed the title
ChenYi015
reviewed
Jun 19, 2025
Signed-off-by: jbhalodia-slack <[email protected]>
jbhalodia-slack
force-pushed
the
setup-code-generator-for-client-code
branch
from
8d2ee0d to
46b994b
Compare
Signed-off-by: jbhalodia-slack <[email protected]>
ChenYi015
approved these changes
Jun 19, 2025
|
@jbhalodia-slack Thanks for the contribution! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ChenYi015
pushed a commit
to ChenYi015/spark-operator
that referenced
this pull request
Jun 25, 2025
* Use code-generator to for clientset, informer, lister Signed-off-by: jbhalodia-slack <[email protected]> * Add README in hack/ for code-generator Signed-off-by: jbhalodia-slack <[email protected]> * Run verify-codegen.sh in tests Signed-off-by: jbhalodia-slack <[email protected]> * make generate Signed-off-by: jbhalodia-slack <[email protected]> * make build-api-docs Signed-off-by: jbhalodia-slack <[email protected]> * update makefile Signed-off-by: jbhalodia-slack <[email protected]> * update makefile Signed-off-by: jbhalodia-slack <[email protected]> * make go-fmt Signed-off-by: jbhalodia-slack <[email protected]> * make generate Signed-off-by: jbhalodia-slack <[email protected]> * run tests Signed-off-by: jbhalodia-slack <[email protected]> * Remove deepcopy-gen since its conflicting with controller-gen Signed-off-by: jbhalodia-slack <[email protected]> * Revert some changes Signed-off-by: jbhalodia-slack <[email protected]> * Generate packages in pkg/client/ Signed-off-by: jbhalodia-slack <[email protected]> * Update year to 2025 in boilerplate.go.txt Signed-off-by: jbhalodia-slack <[email protected]> * Update year to 2025 in types.go Signed-off-by: jbhalodia-slack <[email protected]> --------- Signed-off-by: jbhalodia-slack <[email protected]> (cherry picked from commit ca11a8f)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Use kubernetes/code-generator tool to generate clientset, informers, and listers. These are used by the community to build tools that interface with SparkApplication resources. We're planning to open source a project that heavily depends on these packages.
Proposed changes:
hack/update-codegen.shandhack/verify-codegen.shto use code-generator's kube_codegen.shapi/v1beta2/types.gofile, its required by code-generator+k8s:deepcopy-genand+genclienttags to properly generate client-go packageshack/update-codegen.shto generate packages in pkg/clienthack/verify-codegen.shmake generate,make build-api-docs, andmake go-fmtChange Category
Rationale
Checklist
Additional Notes