Skip to content

Get logger from context #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Get logger from context #2551

merged 1 commit into from
Jun 12, 2025

Conversation

ChenYi015
Copy link
Member

Purpose of this PR

Proposed changes:

  • Get logger from context

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@google-oss-prow google-oss-prow bot requested review from ImpSy and nabuskey June 4, 2025 13:25
@ChenYi015 ChenYi015 marked this pull request as ready for review June 10, 2025 13:07
nabuskey
nabuskey reviewed Jun 10, 2025
View reviewed changes
@ChenYi015 ChenYi015 requested a review from nabuskey June 11, 2025 17:14
nabuskey
nabuskey approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

@google-oss-prow google-oss-prow bot added the lgtm label Jun 11, 2025
@ChenYi015
Copy link
Member Author

/approve

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d14c901 into kubeflow:master Jun 12, 2025
14 of 15 checks passed
ChenYi015 added a commit to ChenYi015/spark-operator that referenced this pull request Jun 25, 2025
@ChenYi015
Get logger from context (kubeflow#2551)
f5dc49f 
Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit d14c901)
@ChenYi015 ChenYi015 mentioned this pull request Jun 25, 2025
Merged
@ChenYi015 ChenYi015 deleted the log-from-context branch June 25, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImpSy ImpSy Awaiting requested review from ImpSy

1 more reviewer

@nabuskey nabuskey nabuskey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nabuskey nabuskey

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChenYi015 @nabuskey