Skip to content

Conversation

ChenYi015
Copy link
Member

Purpose of this PR

Make LDFLAGS can be passed as expected when run make build-operator.

Proposed changes:

  • Update module path in Makefile by fetching it from go.mod file.
  • Update .dockerignore to make the git tree status clean when building the docker image.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@google-oss-prow google-oss-prow bot requested review from ImpSy and nabuskey May 29, 2025 03:52
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ChenYi015
Copy link
Member Author

/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 08dfbc5 into kubeflow:master May 29, 2025
15 checks passed
@ChenYi015 ChenYi015 deleted the cleanup branch May 29, 2025 05:20
@ChenYi015
Copy link
Member Author

/cherrypick release-2.2

@google-oss-robot
Copy link

@ChenYi015: new pull request created: #2544

In response to this:

/cherrypick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants