Skip to content

Add v2 to module path #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

Add v2 to module path #2515

merged 3 commits into from
May 28, 2025

Conversation

ChenYi015
Copy link
Member

Purpose of this PR

Close #2514

Proposed changes:

  • Add v2 to module path

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@ChenYi015
Copy link
Member Author

/assign @jacobsalway

@yuchaoran2011 yuchaoran2011 changed the title Add v2 to moudle path Add v2 to module path May 28, 2025
@google-oss-prow google-oss-prow bot added lgtm and removed lgtm labels May 28, 2025
@yuchaoran2011
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 28, 2025
ChenYi015 added 3 commits May 28, 2025 15:31
@ChenYi015
Add v2 to moudle path
1fecabd 
Signed-off-by: Yi Chen <[email protected]>
@ChenYi015
Update imports
01ebf23 
Signed-off-by: Yi Chen <[email protected]>
@ChenYi015
Update API docs
5336047 
Signed-off-by: Yi Chen <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label May 28, 2025
@ChenYi015 ChenYi015 requested a review from yuchaoran2011 May 28, 2025 12:35
yuchaoran2011
yuchaoran2011 approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@google-oss-prow google-oss-prow bot added the lgtm label May 28, 2025
@yuchaoran2011
Copy link
Contributor

/approve

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 45efb0c into kubeflow:master May 28, 2025
15 checks passed
@ChenYi015 ChenYi015 mentioned this pull request May 29, 2025
Merged
@ChenYi015 ChenYi015 deleted the go-mod branch June 25, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuchaoran2011 yuchaoran2011 yuchaoran2011 approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@ImpSy ImpSy Awaiting requested review from ImpSy

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@yuchaoran2011 yuchaoran2011

@jacobsalway jacobsalway

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to add spark-operator v2 as a dependency
3 participants
@ChenYi015 @yuchaoran2011 @jacobsalway