Skip to content

Conversation

ChenYi015
Copy link
Member

@ChenYi015 ChenYi015 commented Apr 21, 2025

Purpose of this PR

Close #2507.

Proposed changes:

  • Remove clientset, informer and listers generated by code-generator

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Yi Chen <[email protected]>
@ChenYi015
Copy link
Member Author

/assign @vara-bonthu @jacobsalway @ImpSy

Copy link
Member

@jacobsalway jacobsalway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 22, 2025
@ChenYi015
Copy link
Member Author

/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5002c08 into kubeflow:master Apr 27, 2025
15 checks passed
@ChenYi015 ChenYi015 mentioned this pull request May 29, 2025
@ChenYi015 ChenYi015 deleted the remove-code-generator branch June 25, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove generated clientset, informer and listers
4 participants