Skip to content

Conversation

jacobsalway
Copy link
Member

@jacobsalway jacobsalway commented Mar 30, 2025

Purpose of this PR

  • Upgrade to Golang 1.24.1. Golang is backwards compatible and controller-runtime also uses 1.24
  • Also upgrade golangci-lint to 1.64.8 as the linting wasn't running properly with 1.61

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

@jacobsalway jacobsalway changed the title Upgrade to Golang 1.24.1 Upgrade to Golang 1.24.1 and golangci-lint 1.64.8 Mar 30, 2025
@jacobsalway jacobsalway changed the title Upgrade to Golang 1.24.1 and golangci-lint 1.64.8 Upgrade Golang to 1.24.1 and golangci-lint to 1.64.8 Mar 30, 2025
@jacobsalway jacobsalway marked this pull request as ready for review March 30, 2025 08:54
@jacobsalway
Copy link
Member Author

/assign @ChenYi015

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 31, 2025
@google-oss-prow google-oss-prow bot merged commit 3c4ebc7 into kubeflow:master Mar 31, 2025
16 checks passed
@ChenYi015 ChenYi015 mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants