Remove sparkctl

[ChenYi015]

Purpose of this PR

Proposed changes:

• Close Remove sparkctl #2465

Change Category

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Rationale

Checklist

• I have conducted a self-review of my own code.
• I have updated documentation accordingly.
• I have added tests that prove my changes are effective or that my feature works.
• Existing unit tests pass locally with my changes.

Additional Notes

[jacobsalway]

/hold

For at least a day or two to gives others a chance to review

[jacobsalway]

/lgtm
/approve

We've been running the Spark operator internally for ~2 years and I can say I've never used sparkctl. We mainly interact with the the CRs with kubectl or Helm. The only functionality that comes to mind that we should add would be a way to trigger a ScheduledSparkApplication with an annotation.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobsalway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jacobsalway]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nabuskey]

There might be users who are using sparkctl considering it has been in the repo since 2018. I think it's a better idea to mark it as deprecated to give people time to deal with the removal than to remove it right away. I would mark it deprecated in Cobra and notify users in the next release notes.

[vikas-saxena02]

There might be users who are using sparkctl considering it has been in the repo since 2018. I think it's a better idea to mark it as deprecated to give people time to deal with the removal than to remove it right away. I would mark it deprecated in Cobra and notify users in the next release notes.

@nabuskey @jacobsalway @ChenYi015 I have raised #2484 as per the above suggestion to mark sparkctl deprecated

[ChenYi015]

Since we have already mark sparkctl as deprecated in v2.1.1 release notes and README, I think we can continue on removing it.

[vikas-saxena02]

I second this change/proposal.

[nabuskey]

Sounds good to me. We should adopt a deprecation process going forward though. How many versions must released before removed, etc. Especially with changes coming to webhooks and all, having it established helps in the future. We can point at it when users ask questions around field and feature deprecation. I am happy to work on it if interested.

[jacobsalway]

/lgtm

[ChenYi015]

/unhold