fix: webhook fail to add lifecycle to Spark3 executor pods #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix if you have a Spark 3.x spec where the executor has a lifecycle then the webhook will fail to identify the correct container. As described in issue [2457](kubeflow#2457) Signed-off-by: pvbouwel <[email protected]>
Signed-off-by: pvbouwel <[email protected]>
|
@pvbouwel Thank you for reporting the bug and raising a PR to fix it! |
ChenYi015
changed the title
Signed-off-by: pvbouwel <[email protected]>
|
Pushed formatting. Thanks for the info; I will look into the pod template feature such that we can migrate our workflows early on |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ChenYi015
pushed a commit
that referenced
this pull request
Mar 21, 2025
* bugfix: A lifecycle on a spark3 executor should not fail Before this fix if you have a Spark 3.x spec where the executor has a lifecycle then the webhook will fail to identify the correct container. As described in issue [2457](#2457) Signed-off-by: pvbouwel <[email protected]> * tests: Add coverage for spark3 executor with a lifecycle Signed-off-by: pvbouwel <[email protected]> * make go-fmt Signed-off-by: pvbouwel <[email protected]> --------- Signed-off-by: pvbouwel <[email protected]> (cherry picked from commit 3128c7f)
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix if you have a Spark 3.x spec where the executor has a lifecycle then the webhook will fail to identify the correct container. As described in issue 2457
Purpose of this PR
Solve the bug as detailed in #2457 where spark3 executors are blocked if they have a lifecycle
Proposed changes:
Change Category
Rationale
Checklist
Additional Notes