Make image optional #2439
Merged
Make image optional #2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jbhalodia-slack <[email protected]>
Signed-off-by: jbhalodia-slack <[email protected]>
jbhalodia-slack
changed the title
|
@ChenYi015 @jacobsalway @vara-bonthu Can I get a PR review? |
ChenYi015
approved these changes
Feb 20, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
ChenYi015
pushed a commit
that referenced
this pull request
Mar 21, 2025
* Make app.Spec.Driver.Image and app.Spec.Image optional Signed-off-by: jbhalodia-slack <[email protected]> * Make app.Spec.Executor.Image optional Signed-off-by: jbhalodia-slack <[email protected]> (cherry picked from commit d10b8f5)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Proposed changes:
app.Spec.Driver.Imageapp.Spec.Executor.Imageandapp.Spec.Imageoptional as defined in the api-docs. This is the behavior in Spark Operator V1. A use-case here is setting the image viaspark.kubernetes.container.imageSpark configuration in spark-defaults.conf orspec.sparkConf.Change Category
Rationale
Checklist
Additional Notes