Skip to content

Conversation

nabuskey
Copy link
Contributor

@nabuskey nabuskey commented Feb 11, 2025

Purpose of this PR

Currently, the controller uses context.Todo in its main logic, it's usually a better practice to use passed in context if available, instead of using the background context. This will allow it to set context on start up and use the same context in the future.

Proposed changes:

  • Replace context.Todo() with passed in context.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Manabu McCloskey <[email protected]>
@nabuskey nabuskey force-pushed the fix/controller-context branch from 87ef33b to ff02aa5 Compare February 11, 2025 17:41
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Member

@nabuskey Thanks for improving the code quality!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 12, 2025
@google-oss-prow google-oss-prow bot merged commit 2995a0a into kubeflow:master Feb 12, 2025
11 checks passed
@nabuskey nabuskey deleted the fix/controller-context branch February 12, 2025 18:41
ChenYi015 pushed a commit that referenced this pull request Mar 21, 2025
Signed-off-by: Manabu McCloskey <[email protected]>
(cherry picked from commit 2995a0a)
@ChenYi015 ChenYi015 mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants