-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adding seccompProfile RuntimeDefault #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding seccompProfile RuntimeDefault #2397
Conversation
Signed-off-by: Tarek Abouzeid <[email protected]>
Signed-off-by: Tarek Abouzeid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as this is encouraged by EKS and in GKE Autopilot. Worth nothing this will only work in k8s 1.19 and above which conflicts with the 1.16+ support we quote in the README, however I want to reduce the quoted support to the e2e test matrix in the next release anyway.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobsalway The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@tarekabouzeid @biswassri @jacobsalway we should extend this to all examples as well: TODO We are missing a securitycontext in https://github.com/kubeflow/manifests/blob/73cbecfe604e84dfc7c0851630a6eb5733022dea/contrib/spark/sparkapplication_example.yaml and it should be upstreamed to the spark repository
|
kubeflow/manifests#2966 is an example PR, but all examples in https://github.com/kubeflow/spark-operator/tree/master/examples must be changed as well. A point release of spark-operator would help then with the Kubeflow 1.10 release, to reduce our patches |
@juliusvonkohout I will submit another PR to update the examples as well
|
* Adding seccompProfile RuntimeDefault Signed-off-by: Tarek Abouzeid <[email protected]> * updating helm docs Signed-off-by: Tarek Abouzeid <[email protected]> --------- Signed-off-by: Tarek Abouzeid <[email protected]> (cherry picked from commit b241103)
Purpose of this PR
Proposed changes:
seccompProfile type: RuntimeDefault
to controller and webhookChange Category
Rationale
Checklist
Additional Notes
kubeflow/manifests#2912 (comment)