Skip to content

Conversation

dongjiang1989
Copy link

Update the K8s library versions to v1.32, controller-tools to v0.17.1 and controller-runtime to v0.20.0

Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
@rongou
Copy link
Member

rongou commented Jan 22, 2025

/approve
/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rongou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

The code generation failed. Before we merge this, we need to fix that.
/hold

@dongjiang1989
Copy link
Author

Thanks @tenzen-y @rongou
Maybe some bug for code-generator v1.32.x
ref: kubernetes/kubernetes#129774

@tenzen-y
Copy link
Member

Thanks @tenzen-y @rongou Maybe some bug for code-generator v1.32.x ref: kubernetes/kubernetes#129774

I am doubting our directory structure problem. Could you investigate it?

@tenzen-y
Copy link
Member

In favor of #708.
Thanks!
/close

@google-oss-prow google-oss-prow bot closed this Aug 26, 2025
Copy link

@tenzen-y: Closed this PR.

In response to this:

In favor of #708.
Thanks!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants