Skip to content

Automated cherry pick of #982: Fix OIDC settings Cherry pick of #982 on v1.0-branch. #982: Fix OIDC settings#985

Merged
k8s-ci-robot merged 1 commit into
kubeflow:v1.0-branchfrom
PatrickXYS:automated-cherry-pick-of-#982-upstream-v1.0-branch
Mar 4, 2020
Merged

Automated cherry pick of #982: Fix OIDC settings Cherry pick of #982 on v1.0-branch. #982: Fix OIDC settings#985
k8s-ci-robot merged 1 commit into
kubeflow:v1.0-branchfrom
PatrickXYS:automated-cherry-pick-of-#982-upstream-v1.0-branch

Conversation

@PatrickXYS

@PatrickXYS PatrickXYS commented Mar 4, 2020

Copy link
Copy Markdown
Member

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @PatrickXYS. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan

Jeffwan commented Mar 4, 2020

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan

Jeffwan commented Mar 4, 2020

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit 619af8b into kubeflow:v1.0-branch Mar 4, 2020
@PatrickXYS PatrickXYS deleted the automated-cherry-pick-of-#982-upstream-v1.0-branch branch March 9, 2020 01:22
@jlewi jlewi mentioned this pull request Apr 23, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants