Skip to content

Enforce rules on modifying upstream files#3464

Merged
google-oss-prow[bot] merged 1 commit into
masterfrom
block-modifying-upstream-folders
May 16, 2026
Merged

Enforce rules on modifying upstream files#3464
google-oss-prow[bot] merged 1 commit into
masterfrom
block-modifying-upstream-folders

Conversation

@juliusvonkohout
Copy link
Copy Markdown
Member

Added a rule prohibiting changes to files containing '/upstream' without using synchronization scripts.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 16, 2026 14:45
@juliusvonkohout
Copy link
Copy Markdown
Member Author

@danish9039 @Raakshass for lgtm
/approve

@google-oss-prow google-oss-prow Bot requested a review from kimwnasptd May 16, 2026 14:46
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates Copilot review guidance to prevent direct changes to upstream-managed paths unless synchronization scripts are used.

Changes:

  • Adds a rule for blocking pull requests that modify upstream-managed paths without using scripts under /scripts.

@danish9039
Copy link
Copy Markdown
Member

/lgtm

@google-oss-prow google-oss-prow Bot added the lgtm label May 16, 2026
@google-oss-prow google-oss-prow Bot merged commit 6095d6b into master May 16, 2026
16 checks passed
@google-oss-prow google-oss-prow Bot deleted the block-modifying-upstream-folders branch May 16, 2026 16:37
@Raakshass
Copy link
Copy Markdown
Contributor

reviewed the upstream folder protection rule is clean singleline addition, correct scoping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants