Update kubeflow/notebooks manifests from v1.11.0-rc.1#3429
Conversation
There was a problem hiding this comment.
Pull request overview
Synchronizes Kubeflow Notebooks v1 component manifests to v1.11.0-rc.1, updating the in-repo upstream YAMLs (controllers + web apps) and the component version matrix in README.md. Adds a helper script intended to automate future sync PRs for the notebooks-v1 set.
Changes:
- Add
scripts/synchronize-notebooks-v1-manifests.shto automate syncing notebooks-v1 manifests fromkubeflow/notebooks. - Update multiple notebooks-related components to use
ghcr.io/kubeflow/notebooks/*images with tagv1.11.0-rc.1, plus associated CRD/RBAC refreshes from upstream. - Update default notebook server image tags in the Jupyter web-app spawner UI config and bump the README component version links to
v1.11.0-rc.1.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/synchronize-notebooks-v1-manifests.sh | New sync script for notebooks-v1 manifests and README link updates |
| applications/volumes-web-app/upstream/base/kustomization.yaml | Switch image to ghcr.io/kubeflow/notebooks/volumes-web-app + tag v1.11.0-rc.1 |
| applications/volumes-web-app/upstream/base/deployment.yaml | Switch image registry path; bump embedded filebrowser image tag |
| applications/tensorboard/tensorboards-web-app/upstream/base/kustomization.yaml | Switch image to ghcr.io/kubeflow/notebooks/tensorboards-web-app + tag v1.11.0-rc.1 |
| applications/tensorboard/tensorboards-web-app/upstream/base/deployment.yaml | Switch image registry path |
| applications/tensorboard/tensorboard-controller/upstream/rbac/role.yaml | Refresh controller ClusterRole rules from upstream |
| applications/tensorboard/tensorboard-controller/upstream/manager/manager.yaml | Switch controller image registry path |
| applications/tensorboard/tensorboard-controller/upstream/crd/bases/tensorboard.kubeflow.org_tensorboards.yaml | Refresh CRD schema/metadata from upstream controller-gen output |
| applications/tensorboard/tensorboard-controller/upstream/base/kustomization.yaml | Switch image to ghcr.io/kubeflow/notebooks/tensorboard-controller + tag v1.11.0-rc.1 |
| applications/pvcviewer-controller/upstream/rbac/role.yaml | Refresh controller ClusterRole rules from upstream |
| applications/pvcviewer-controller/upstream/manager/manager.yaml | Switch controller image registry path |
| applications/pvcviewer-controller/upstream/crd/bases/kubeflow.org_pvcviewers.yaml | Refresh CRD schema/metadata from upstream controller-gen output |
| applications/pvcviewer-controller/upstream/base/kustomization.yaml | Switch image to ghcr.io/kubeflow/notebooks/pvcviewer-controller + tag v1.11.0-rc.1 |
| applications/jupyter/notebook-controller/upstream/rbac/role.yaml | Refresh controller ClusterRole rules (ordering/structure) from upstream |
| applications/jupyter/notebook-controller/upstream/manager/manager.yaml | Switch controller image registry path |
| applications/jupyter/notebook-controller/upstream/crd/bases/kubeflow.org_notebooks.yaml | Refresh CRD schema/metadata from upstream controller-gen output |
| applications/jupyter/notebook-controller/upstream/base/kustomization.yaml | Switch image to ghcr.io/kubeflow/notebooks/notebook-controller + tag v1.11.0-rc.1 |
| applications/jupyter/jupyter-web-app/upstream/base/kustomization.yaml | Switch image to ghcr.io/kubeflow/notebooks/jupyter-web-app + tag v1.11.0-rc.1 |
| applications/jupyter/jupyter-web-app/upstream/base/deployment.yaml | Switch web-app image registry path |
| applications/jupyter/jupyter-web-app/upstream/base/configs/spawner_ui_config.yaml | Bump default notebook server image tags to v1.11.0-rc.1 |
| README.md | Update notebooks-related component upstream links to kubeflow/notebooks v1.11.0-rc.1 |
|
The copilot comments are all relevant but IMO fixing them only makes sense in a separate PR as this PR just reuses the existing scripts 😅 |
|
/hold |
|
@christian-heusel can we group the https://github.com/kubeflow/manifests/blob/master/example/kustomization.yaml resources by |
Link: kubeflow#3430 (comment) Link: kubeflow#3429 (comment) Signed-off-by: Christian Heusel <christian@heusel.eu>
c7ff7a8 to
e761115
Compare
|
/unhold |
Link: kubeflow#3430 (comment) Link: kubeflow#3429 (comment) Signed-off-by: Christian Heusel <christian@heusel.eu>
e761115 to
6cb668c
Compare
|
/hold We will cut a 1.11.0-rc.2 with some updates to the example notebook servers and rebase this PR |
Link: kubeflow#3430 (comment) Link: kubeflow#3429 (comment) Signed-off-by: Christian Heusel <christian@heusel.eu>
6cb668c to
000bbae
Compare
Signed-off-by: Christian Heusel <christian@heusel.eu>
|
I'm currently rebasing this PR 🚧 Edit: Done ✅ |
Link: kubeflow#3430 (comment) Link: kubeflow#3429 (comment) Signed-off-by: Christian Heusel <christian@heusel.eu>
000bbae to
da1232b
Compare
|
@juliusvonkohout from our side this can be merged, after talking to @thesuperzapper on the WG call we decided to do a separate PR regarding the image upgrades, so this one can be merged / reviewed if you're happy with it 🤗 /unhold |
|
@juliusvonkohout this one is ready to review/merge and, and we will follow up with a new syncronise for |
|
Thank you lets remove the old notebook helm charts in a follow up pr. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
Sync the upstream
notebooks-v1release candidate manifests to see if there are any blockers remaining.📦 Dependencies
none
🐛 Related Issues
none
✅ Contributor Checklist