Skip to content

Update kubeflow/notebooks manifests from v1.11.0-rc.1#3429

Merged
juliusvonkohout merged 2 commits into
kubeflow:masterfrom
christian-heusel:synchronize-notebooks-v1-notebooks-v1-manifests-v1.11.0-rc.1
Apr 11, 2026
Merged

Update kubeflow/notebooks manifests from v1.11.0-rc.1#3429
juliusvonkohout merged 2 commits into
kubeflow:masterfrom
christian-heusel:synchronize-notebooks-v1-notebooks-v1-manifests-v1.11.0-rc.1

Conversation

@christian-heusel
Copy link
Copy Markdown
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Sync the upstream notebooks-v1 release candidate manifests to see if there are any blockers remaining.

📦 Dependencies

none

🐛 Related Issues

none

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Synchronizes Kubeflow Notebooks v1 component manifests to v1.11.0-rc.1, updating the in-repo upstream YAMLs (controllers + web apps) and the component version matrix in README.md. Adds a helper script intended to automate future sync PRs for the notebooks-v1 set.

Changes:

  • Add scripts/synchronize-notebooks-v1-manifests.sh to automate syncing notebooks-v1 manifests from kubeflow/notebooks.
  • Update multiple notebooks-related components to use ghcr.io/kubeflow/notebooks/* images with tag v1.11.0-rc.1, plus associated CRD/RBAC refreshes from upstream.
  • Update default notebook server image tags in the Jupyter web-app spawner UI config and bump the README component version links to v1.11.0-rc.1.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/synchronize-notebooks-v1-manifests.sh New sync script for notebooks-v1 manifests and README link updates
applications/volumes-web-app/upstream/base/kustomization.yaml Switch image to ghcr.io/kubeflow/notebooks/volumes-web-app + tag v1.11.0-rc.1
applications/volumes-web-app/upstream/base/deployment.yaml Switch image registry path; bump embedded filebrowser image tag
applications/tensorboard/tensorboards-web-app/upstream/base/kustomization.yaml Switch image to ghcr.io/kubeflow/notebooks/tensorboards-web-app + tag v1.11.0-rc.1
applications/tensorboard/tensorboards-web-app/upstream/base/deployment.yaml Switch image registry path
applications/tensorboard/tensorboard-controller/upstream/rbac/role.yaml Refresh controller ClusterRole rules from upstream
applications/tensorboard/tensorboard-controller/upstream/manager/manager.yaml Switch controller image registry path
applications/tensorboard/tensorboard-controller/upstream/crd/bases/tensorboard.kubeflow.org_tensorboards.yaml Refresh CRD schema/metadata from upstream controller-gen output
applications/tensorboard/tensorboard-controller/upstream/base/kustomization.yaml Switch image to ghcr.io/kubeflow/notebooks/tensorboard-controller + tag v1.11.0-rc.1
applications/pvcviewer-controller/upstream/rbac/role.yaml Refresh controller ClusterRole rules from upstream
applications/pvcviewer-controller/upstream/manager/manager.yaml Switch controller image registry path
applications/pvcviewer-controller/upstream/crd/bases/kubeflow.org_pvcviewers.yaml Refresh CRD schema/metadata from upstream controller-gen output
applications/pvcviewer-controller/upstream/base/kustomization.yaml Switch image to ghcr.io/kubeflow/notebooks/pvcviewer-controller + tag v1.11.0-rc.1
applications/jupyter/notebook-controller/upstream/rbac/role.yaml Refresh controller ClusterRole rules (ordering/structure) from upstream
applications/jupyter/notebook-controller/upstream/manager/manager.yaml Switch controller image registry path
applications/jupyter/notebook-controller/upstream/crd/bases/kubeflow.org_notebooks.yaml Refresh CRD schema/metadata from upstream controller-gen output
applications/jupyter/notebook-controller/upstream/base/kustomization.yaml Switch image to ghcr.io/kubeflow/notebooks/notebook-controller + tag v1.11.0-rc.1
applications/jupyter/jupyter-web-app/upstream/base/kustomization.yaml Switch image to ghcr.io/kubeflow/notebooks/jupyter-web-app + tag v1.11.0-rc.1
applications/jupyter/jupyter-web-app/upstream/base/deployment.yaml Switch web-app image registry path
applications/jupyter/jupyter-web-app/upstream/base/configs/spawner_ui_config.yaml Bump default notebook server image tags to v1.11.0-rc.1
README.md Update notebooks-related component upstream links to kubeflow/notebooks v1.11.0-rc.1

Comment thread scripts/synchronize-notebooks-v1-manifests.sh
Comment thread scripts/synchronize-notebooks-v1-manifests.sh
Comment thread scripts/synchronize-notebooks-v1-manifests.sh
@christian-heusel
Copy link
Copy Markdown
Contributor Author

The copilot comments are all relevant but IMO fixing them only makes sense in a separate PR as this PR just reuses the existing scripts 😅

@christian-heusel christian-heusel marked this pull request as ready for review March 27, 2026 17:59
@christian-heusel
Copy link
Copy Markdown
Contributor Author

/hold

@thesuperzapper
Copy link
Copy Markdown
Member

@christian-heusel can we group the https://github.com/kubeflow/manifests/blob/master/example/kustomization.yaml resources by notebooks v1 for the components which come from this sync.

christian-heusel added a commit to christian-heusel/manifests that referenced this pull request Apr 1, 2026
Link: kubeflow#3430 (comment)
Link: kubeflow#3429 (comment)
Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel christian-heusel force-pushed the synchronize-notebooks-v1-notebooks-v1-manifests-v1.11.0-rc.1 branch from c7ff7a8 to e761115 Compare April 1, 2026 13:52
@google-oss-prow google-oss-prow Bot added size/XL and removed size/L labels Apr 1, 2026
@christian-heusel
Copy link
Copy Markdown
Contributor Author

/unhold

Comment thread applications/notebooks-v1/overlays/istio/kustomization.yaml
christian-heusel added a commit to christian-heusel/manifests that referenced this pull request Apr 1, 2026
Link: kubeflow#3430 (comment)
Link: kubeflow#3429 (comment)
Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel christian-heusel force-pushed the synchronize-notebooks-v1-notebooks-v1-manifests-v1.11.0-rc.1 branch from e761115 to 6cb668c Compare April 1, 2026 17:45
@thesuperzapper
Copy link
Copy Markdown
Member

thesuperzapper commented Apr 2, 2026

/hold

We will cut a 1.11.0-rc.2 with some updates to the example notebook servers and rebase this PR

christian-heusel added a commit to christian-heusel/manifests that referenced this pull request Apr 8, 2026
Link: kubeflow#3430 (comment)
Link: kubeflow#3429 (comment)
Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel christian-heusel force-pushed the synchronize-notebooks-v1-notebooks-v1-manifests-v1.11.0-rc.1 branch from 6cb668c to 000bbae Compare April 8, 2026 18:26
Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel
Copy link
Copy Markdown
Contributor Author

christian-heusel commented Apr 9, 2026

I'm currently rebasing this PR 🚧

Edit: Done ✅

Link: kubeflow#3430 (comment)
Link: kubeflow#3429 (comment)
Signed-off-by: Christian Heusel <christian@heusel.eu>
@christian-heusel christian-heusel force-pushed the synchronize-notebooks-v1-notebooks-v1-manifests-v1.11.0-rc.1 branch from 000bbae to da1232b Compare April 9, 2026 12:47
@christian-heusel
Copy link
Copy Markdown
Contributor Author

@juliusvonkohout from our side this can be merged, after talking to @thesuperzapper on the WG call we decided to do a separate PR regarding the image upgrades, so this one can be merged / reviewed if you're happy with it 🤗

/unhold

@thesuperzapper
Copy link
Copy Markdown
Member

@juliusvonkohout this one is ready to review/merge and, and we will follow up with a new syncronise for v1.11.0-rc.2 which wont change the manifests, but will update the example notebook servers with new pytorch.

@juliusvonkohout
Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

lets remove the old notebook helm charts in a follow up pr.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout merged commit f206a23 into kubeflow:master Apr 11, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants