Skip to content

Update kubeflow/spark-operator manifests to 2.2.0#3146

Merged
google-oss-prow[bot] merged 3 commits into
masterfrom
synchronize-spark-operator-manifests-2.2.0
Jun 3, 2025
Merged

Update kubeflow/spark-operator manifests to 2.2.0#3146
google-oss-prow[bot] merged 3 commits into
masterfrom
synchronize-spark-operator-manifests-2.2.0

Conversation

@juliusvonkohout
Copy link
Copy Markdown
Member

Lets test whether the security context patches are still needed.

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow Bot requested a review from kimwnasptd May 29, 2025 17:50
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Copy Markdown
Member Author

@akagami-harsh do you mind checking, whether the seccomprofile in the securitycontext is now upstream ?

Comment thread README.md Outdated
| Kubeflow Pipelines | apps/pipeline/upstream | [2.5.0](https://github.com/kubeflow/pipelines/tree/2.5.0/manifests/kustomize) |
| Kubeflow Model Registry | apps/model-registry/upstream | [v0.2.18](https://github.com/kubeflow/model-registry/tree/v0.2.18/manifests/kustomize) |
| Spark Operator | apps/spark/spark-operator | [2.1.1](https://github.com/kubeflow/spark-operator/tree/v2.1.1) |
| Spark Operator | apps/spark/spark-operator | 2.2.0) |
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunal-511 something went wrong with the synchronization script.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay checking it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue is that sed command in the script is only looking for the version number pattern and doesn't account for the markdown link format.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update it in script to account for the link in md format

@akagami-harsh
Copy link
Copy Markdown
Member

@akagami-harsh do you mind checking, whether the seccomprofile in the securitycontext is now upstream ?

Yes they are upstream : https://github.com/kubeflow/spark-operator/blame/08dfbc5fc958b91d3be4d79a0848b44b72f7d98b/charts/spark-operator-chart/values.yaml#L184C2-L184C2

@juliusvonkohout
Copy link
Copy Markdown
Member Author

/approve

@kubeflow kubeflow deleted a comment from google-oss-prow Bot Jun 3, 2025
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@tarekabouzeid
Copy link
Copy Markdown
Member

/lgtm

@google-oss-prow google-oss-prow Bot added the lgtm label Jun 3, 2025
@google-oss-prow google-oss-prow Bot merged commit 4d81e63 into master Jun 3, 2025
12 checks passed
@juliusvonkohout juliusvonkohout deleted the synchronize-spark-operator-manifests-2.2.0 branch June 3, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants