Skip to content

update OWNERS#1656

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:update_owners
Nov 18, 2020
Merged

update OWNERS#1656
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
thesuperzapper:update_owners

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

As I end up touching so much of this repo (given how many pieces the notebook working group controls), its probably easier if I am added to the root OWNERS files.

@thesuperzapper

thesuperzapper commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

@PatrickXYS can you approve this?

For example, I cant approve #1654, unless I am added to this OWNERS.

@PatrickXYS

Copy link
Copy Markdown
Member

@thesuperzapper Besides adding you into root OWNER, I'd like to keep more fine-grained ownership to add you into test folder owner and create OWNERs file with yourself listed in common/centraldashboard folder

@thesuperzapper thesuperzapper changed the title add thesuperzapper to OWNERS update OWNERS Nov 18, 2020
@thesuperzapper

Copy link
Copy Markdown
Member Author

@PatrickXYS I have done this, and also added @kimwnasptd, who is also a lead of the Notebook WG

@PatrickXYS

Copy link
Copy Markdown
Member

Thanks @thesuperzapper

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatrickXYS, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cb844d3 into kubeflow:master Nov 18, 2020
@thesuperzapper thesuperzapper deleted the update_owners branch November 16, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants