Enable central dashboard to use configmap and remove manifest link#1654
Merged
k8s-ci-robot merged 2 commits intoNov 18, 2020
Merged
Conversation
Jeffwan
changed the title
Jeffwan
force-pushed
the
remove_central_dashboard_artifacts
branch
from
8c73221 to
4bdb301
Compare
Member
Author
k8s-ci-robot
requested review from
PatrickXYS,
SachinVarghese,
berndverst and
thesuperzapper
Member
|
/lgtm |
Member
|
/lgtm |
Member
Author
|
@thesuperzapper @SachinVarghese Can you help approve the change? |
Contributor
|
@kubeflow/wg-notebook-leads Can you update OWNERS so that you can approve this PR? |
1 task
Member
|
I can approve though if you're eager to go |
Member
Author
|
/hold |
Merged
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold cancel |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 18, 2020
…hboard (#1658) * Remove metadata link from central dashboard * Enable central dashboard to use configmap * Regenerate tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
For safety reason, I only patch configmap env, this should be good enough to customize links in central dashbaord. We need to bring this back to 1.2..
Checklist:
cd manifests/testsmake generate-changed-onlymake test