Skip to content

[IBM] Update notebooks and profiles image tags#1652

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
pvaneck:ibm-image-tags
Nov 17, 2020
Merged

[IBM] Update notebooks and profiles image tags#1652
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
pvaneck:ibm-image-tags

Conversation

@pvaneck

@pvaneck pvaneck commented Nov 17, 2020

Copy link
Copy Markdown
Member

Description of your changes:
This PR updates the image tags that were listed in the IBM stack based on updates in #1645.

Ideally, we get rid of the hard-coding here and use each component's base_v3 directly, but I'm hesitant to do so based on #1285 . So for now, just update the relevant image tags in stacks/ibm.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@pvaneck

pvaneck commented Nov 17, 2020

Copy link
Copy Markdown
Member Author

/cc @animeshsingh

@animeshsingh

Copy link
Copy Markdown
Contributor

thanks @pvaneck

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, pvaneck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7351704 into kubeflow:master Nov 17, 2020
@animeshsingh

Copy link
Copy Markdown
Contributor

Does this need a cherry pick?

@thesuperzapper

Copy link
Copy Markdown
Member

@animeshsingh why is #1285 stopping you from removing the hard coding?

@pvaneck

pvaneck commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

Hey @thesuperzapper. If I remove just the image: sections, then it will just use the images that are listed in the base/deployment.yaml files which are old. (e.g. https://github.com/kubeflow/manifests/blob/master/jupyter/notebook-controller/base/deployment.yaml#L13)

Initially, I was changing everything to directly use the base_v3 directories so as to pick up the new image tags, however, seems previously there were some name change concerns raised by @adrian555 , and it seems like the original intent of the custom structure in stacks/IBM was to avoid the namePrefix being applied to something already with the prefix (e.g. jupyter-web-app-jupyter-web-app). Overall this may not be a big deal, but for now, since I was uncertain about all this and its side effects, I just opted to keep names of things consistent for this release by only updating the image tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants