Skip to content

feat: remove kf metadata server#1638

Merged
k8s-ci-robot merged 2 commits into
kubeflow:masterfrom
Bobgy:rm_metadata_server
Nov 12, 2020
Merged

feat: remove kf metadata server#1638
k8s-ci-robot merged 2 commits into
kubeflow:masterfrom
Bobgy:rm_metadata_server

Conversation

@Bobgy

@Bobgy Bobgy commented Nov 12, 2020

Copy link
Copy Markdown
Contributor

Which issue is resolved by this Pull Request:
Part of kubeflow/metadata#250

Description of your changes:

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@google-cla google-cla Bot added the cla: yes label Nov 12, 2020
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy

Bobgy commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

/assign @Jeffwan @PatrickXYS @neuromage
I'm not sure we want to do this now, a problem is that when KF metadata UI virtual service is removed. I think users cannot access KF metadata server either, so I think there's no reason to keep metadata server too.

@PatrickXYS

Copy link
Copy Markdown
Member

I think removal sounds reasonable since we have already removed metadata UI virtualservice.

SGTM

/cc @kubeflow/wg-notebook-leads

@Jeffwan

Jeffwan commented Nov 12, 2020

Copy link
Copy Markdown
Member

@Bobgy @PatrickXYS I think it makes sense to remove all and only leave grpc deployment and server there. kubeflow/metadata#250

@Jeffwan

Jeffwan commented Nov 12, 2020

Copy link
Copy Markdown
Member

/lgtm

@Jeffwan

Jeffwan commented Nov 12, 2020

Copy link
Copy Markdown
Member

kubeflow/kubeflow#5404 PR to remove link in central dashboard

@Bobgy Bobgy deleted the rm_metadata_server branch November 13, 2020 10:55
Bobgy added a commit to Bobgy/manifests that referenced this pull request Nov 13, 2020
* feat: remove kf metadata server

* update snapshots
k8s-ci-robot pushed a commit that referenced this pull request Nov 13, 2020
* feat: remove kf metadata server

* update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants