Skip to content

Presubmit kicked off by istio_dex manifests#1630

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:change_prow_config
Nov 11, 2020
Merged

Presubmit kicked off by istio_dex manifests#1630
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:change_prow_config

Conversation

@PatrickXYS

@PatrickXYS PatrickXYS commented Nov 10, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Since cloud providers are changing kfdef/* manifests frequently, and we should only kick off E2E tests when kfctl_istio_dex manifests.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@google-cla google-cla Bot added the cla: yes label Nov 10, 2020
@PatrickXYS

PatrickXYS commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

/cc @Jeffwan

@k8s-ci-robot k8s-ci-robot requested a review from Jeffwan November 10, 2020 21:00
Jeffwan
Jeffwan approved these changes Nov 10, 2020
View reviewed changes
Comment thread prow_config.yaml
- jupyter/*
- katib/*
- kfdef/*
- kfdef/kfctl_istio_dex*

@Jeffwan Jeffwan Nov 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

em. I thought kfdef/* is a super set of kfdef/kfctl_istio_dex*. Any reason to change it?

@PatrickXYS PatrickXYS Nov 10, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if cloud providers are changing kfctl_aws / kfctl_ibm, kfctl_openshift, it should not kick off E2E test because it's not agnostic change.

And I found folks may change very frequently and this change can help speed up and reserve resources.

@Jeffwan Jeffwan Nov 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Make sense. kfctl_istio_dex should be good enough.

@k8s-ci-robot

k8s-ci-robot commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan

Jeffwan commented Nov 11, 2020

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 7f4d943 into kubeflow:master Nov 11, 2020
PatrickXYS pushed a commit to PatrickXYS/manifests that referenced this pull request Nov 11, 2020
Presubmit kicked off by istio_dex manifests (kubeflow#1630)
0dae61b
@PatrickXYS PatrickXYS mentioned this pull request Nov 11, 2020
Merged
1 task
k8s-ci-robot pushed a commit that referenced this pull request Nov 11, 2020
Cherry-Pick AWS PR #1629 #1630 (#1631)
2730201 
* Remove Tensorboard for AWS 1.2 Manifests (#1629)

* Presubmit kicked off by istio_dex manifests (#1630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

@vkoukis vkoukis Awaiting requested review from vkoukis

1 more reviewer

@Jeffwan Jeffwan Jeffwan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Jeffwan Jeffwan

Labels

approved cla: yes lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PatrickXYS @k8s-ci-robot @Jeffwan