Skip to content

Remove Tensorboard for AWS 1.2 Manifests#1629

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:rm_tensorboard
Nov 10, 2020
Merged

Remove Tensorboard for AWS 1.2 Manifests#1629
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:rm_tensorboard

Conversation

@PatrickXYS

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Found we removed tensorboard manifests in master branch previously

#1459

Remove tensorboard in AWS 1.2 manifests.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@PatrickXYS

Copy link
Copy Markdown
Member Author

/cc @Jeffwan

@k8s-ci-robot k8s-ci-robot requested a review from Jeffwan November 10, 2020 21:00
@Jeffwan

Jeffwan commented Nov 10, 2020

Copy link
Copy Markdown
Member

/lgtm

I may forget to delete this in the past. Good catch

@PatrickXYS

Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3b921da into kubeflow:master Nov 10, 2020
PatrickXYS pushed a commit to PatrickXYS/manifests that referenced this pull request Nov 10, 2020
@PatrickXYS PatrickXYS mentioned this pull request Nov 10, 2020
1 task
k8s-ci-robot pushed a commit that referenced this pull request Nov 11, 2020
* Remove Tensorboard for AWS 1.2 Manifests (#1629)

* Presubmit kicked off by istio_dex manifests (#1630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants