Skip to content

Pin test manifest to v1.2-branch#1624

Merged
k8s-ci-robot merged 1 commit into
kubeflow:v1.2-branchfrom
Jeffwan:pin_1.2_test_branch
Nov 10, 2020
Merged

Pin test manifest to v1.2-branch#1624
k8s-ci-robot merged 1 commit into
kubeflow:v1.2-branchfrom
Jeffwan:pin_1.2_test_branch

Conversation

@Jeffwan

@Jeffwan Jeffwan commented Nov 10, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
for 1.2 release

Description of your changes:
Make prow periodical test against v1.2-branch

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@Jeffwan

Jeffwan commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

/cc @PatrickXYS

@PatrickXYS

Copy link
Copy Markdown
Member

/lgtm
/approve

Since I enabled v1.2-branch presubmit as well, this PR will be merged until test succeed

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan

Jeffwan commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

Since I enabled v1.2-branch presubmit as well, this PR will be merged until test succeed

Perfect

@k8s-ci-robot k8s-ci-robot merged commit 92d6828 into kubeflow:v1.2-branch Nov 10, 2020
@Jeffwan Jeffwan deleted the pin_1.2_test_branch branch November 10, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants