Skip to content

Add AWS Periodic Tests#1612

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:add_aws_tests
Nov 5, 2020
Merged

Add AWS Periodic Tests#1612
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:add_aws_tests

Conversation

@PatrickXYS

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Add AWS Periodic Tests to test orchestration on Kubeflow AWS.

Also removes periodic tests for e2e and unit tests, since no one will check it daily and see if they succeed or fail, thus, it only consume resources without any contribution.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@PatrickXYS

Copy link
Copy Markdown
Member Author

/cc @Jeffwan

@terrytangyuan terrytangyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatrickXYS, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PatrickXYS,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1068243 into kubeflow:master Nov 5, 2020
@PatrickXYS PatrickXYS deleted the add_aws_tests branch November 5, 2020 21:24
Comment thread prow_config.yaml
kwargs:
build_and_apply: false
config_path: https://raw.githubusercontent.com/kubeflow/manifests/master/kfdef/kfctl_istio_dex.yaml No newline at end of file
config_path: https://raw.githubusercontent.com/kubeflow/manifests/master/kfdef/kfctl_istio_dex.yaml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

em. I know kubeflow minimum distribution is still being discussed, but I hope to keep it until we figure it out If this is not a problem at this moment.

@Jeffwan

Jeffwan commented Nov 5, 2020

Copy link
Copy Markdown
Member

Also removes periodic tests for e2e and unit tests, since no one will check it daily and see if they succeed or fail, thus, it only consume resources without any contribution.

This doesn't make sense to me. It's ok to add AWS or other cloud provider cases here. That's a separate story. AWS test won't guarantee kubeflow manifest wok for other platforms.

@PatrickXYS

Copy link
Copy Markdown
Member Author

Also removes periodic tests for e2e and unit tests, since no one will check it daily and see if they succeed or fail, thus, it only consume resources without any contribution.

This doesn't make sense to me. It's ok to add AWS or other cloud provider cases here. That's a separate story. AWS test won't guarantee kubeflow manifest wok for other platforms.

I agree with the idea AWS test is separate story. The reason I removed minimum distribution periodic job is presubmit should be able to detect any failures, only situation I can come up with is establishing Kubeflow-Kubernetes Version Compatibility Matrix, but I don't think we want to support before 1.2.

@Jeffwan

Jeffwan commented Nov 6, 2020

Copy link
Copy Markdown
Member

@PatrickXYS

Kubeflow compability matrics is a separate story.. We will give some matrix in 1.2 but that's not related.

I would suggest to bring it back since this is cloud agnostic and only have some core components and can reflect master/branch control plane status. Presubmit does help but this won't cover all the cases. For example, some dependency change (like kfctl, kuebrnetes cluster version), Github update (tar.gz or https issue in the past) or GCR outage, etc. This help us make quick response to Kubernete users.

We already had the pain in 1.1 and hope at least we can run it during release cycle.

@PatrickXYS

Copy link
Copy Markdown
Member Author

@Jeffwan

Thank you for explanations! That sounds good to me, I'll add those periodic test back

@PatrickXYS PatrickXYS mentioned this pull request Nov 6, 2020
1 task
@PatrickXYS

Copy link
Copy Markdown
Member Author

Created PR #1615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants