Add E2E Test on Kubeflow Shared Test-infra by PatrickXYS · Pull Request #1601 · kubeflow/community-distribution

PatrickXYS · 2020-11-02T02:52:09Z

Which issue is resolved by this Pull Request:
For Kubeflow 1.2 release, we have decided to move E2E test back for kfctl + manifests

Related kfctl PR: kubeflow/kfctl#427
This PR will only be able to merge until kfctl PR merged.

Description of your changes:

Add E2E test
Change E2E configuration to make it compatible on Shared Test-infra

Checklist:

Unit tests have been rebuilt:
1. cd manifests/tests
2. make generate-changed-only
3. make test

kubeflow-bot · 2020-11-02T02:52:15Z

This change is

PatrickXYS · 2020-11-02T02:55:10Z

/cc @Jeffwan @yanniszark @terrytangyuan @animeshsingh

Jeffwan · 2020-11-02T04:17:12Z

What's the kfctl version it uses?

PatrickXYS · 2020-11-02T17:41:28Z

Master branch

k8s-ci-robot · 2020-11-03T00:33:04Z

@PatrickXYS: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
kubeflow-manifests-presubmit	`cc4acd6`	link	`/test kubeflow-manifests-presubmit`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PatrickXYS · 2020-11-04T00:31:32Z

/test ?

aws-kf-ci-bot · 2020-11-04T00:31:35Z

@PatrickXYS: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-11-04T00:31:36Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit

Use /test all to run all jobs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-04T00:33:00Z

/test ?

aws-kf-ci-bot · 2020-11-04T00:33:03Z

@PatrickXYS: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-11-04T00:33:05Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit

Use /test all to run all jobs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-04T00:34:48Z

/test ?

aws-kf-ci-bot · 2020-11-04T00:34:51Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit-e2e

Use /test all to run all jobs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-11-04T00:34:52Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit

Use /test all to run all jobs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-04T00:35:11Z

/test kubeflow-manifests-presubmit-e2e

k8s-ci-robot · 2020-11-04T00:35:15Z

@PatrickXYS: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit

Use /test all to run all jobs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-04T01:36:16Z

The test works

/cc @Jeffwan @andreyvelich

Can you help approve this PR? I put hold tag here, so it won't be merged immediately

Jeffwan · 2020-11-04T03:09:35Z

/lgtm
/approve

PatrickXYS · 2020-11-04T18:05:38Z

@yanniszark @jlewi @animeshsingh

Can you help approve the PR?

PatrickXYS · 2020-11-04T20:42:11Z

/test ?

aws-kf-ci-bot · 2020-11-04T20:42:15Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit-e2e

Use /test all to run all jobs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-11-04T20:42:16Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit

Use /test all to run all jobs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-04T20:45:12Z

/approve

k8s-ci-robot · 2020-11-04T20:45:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [PatrickXYS]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PatrickXYS · 2020-11-04T20:46:44Z

/hold

PatrickXYS · 2020-11-04T20:46:50Z

/test ?

aws-kf-ci-bot · 2020-11-04T20:46:54Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit-e2e

Use /test all to run all jobs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-11-04T20:46:55Z

@PatrickXYS: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-cla Bot added the cla: yes label Nov 2, 2020

k8s-ci-robot requested review from Jeffwan and krishnadurai November 2, 2020 02:52

k8s-ci-robot added the size/L label Nov 2, 2020

k8s-ci-robot requested review from animeshsingh, terrytangyuan and yanniszark November 2, 2020 02:55

Jeffwan reviewed Nov 2, 2020

View reviewed changes

Comment thread prow_config.yaml Outdated

Comment thread tests/workflows/components/workflows.libsonnet Outdated

terrytangyuan reviewed Nov 2, 2020

View reviewed changes

Comment thread tests/workflows/components/workflows.libsonnet Outdated

Add E2E Test on Kubeflow Shared Test-infra

41bd92f

PatrickXYS force-pushed the e2e_test branch from 8dd811a to 41bd92f Compare November 2, 2020 19:07

Use different branches

cc4acd6

PatrickXYS mentioned this pull request Nov 4, 2020

Remove kubeflow/manifests presubmit kubernetes/test-infra#19833

Merged

k8s-ci-robot requested review from Jeffwan and andreyvelich November 4, 2020 01:36

k8s-ci-robot assigned Jeffwan Nov 4, 2020

k8s-ci-robot added the lgtm label Nov 4, 2020

k8s-ci-robot added the approved label Nov 4, 2020

k8s-ci-robot added the do-not-merge/hold label Nov 4, 2020

k8s-ci-robot merged commit f0f5fbb into kubeflow:master Nov 4, 2020

PatrickXYS mentioned this pull request Nov 4, 2020

[IBM] Remap components to application for IBM stack #1603

Merged

1 task

Conversation

PatrickXYS commented Nov 2, 2020

Uh oh!

kubeflow-bot commented Nov 2, 2020

Uh oh!

PatrickXYS commented Nov 2, 2020

Uh oh!

Uh oh!

Uh oh!

Jeffwan commented Nov 2, 2020

Uh oh!

PatrickXYS commented Nov 2, 2020

Uh oh!

Uh oh!

k8s-ci-robot commented Nov 3, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

aws-kf-ci-bot commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

aws-kf-ci-bot commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

aws-kf-ci-bot commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jeffwan commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

aws-kf-ci-bot commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

aws-kf-ci-bot commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PatrickXYS commented Nov 4, 2020 •

edited

Loading