Add a kustomize function to remove namespace#1446
Merged
Merged
Conversation
* This is needed to produce YAMLs that are compatible with ACM related to * GoogleCloudPlatform/kubeflow-distribution#27 kustomize function to remove namespace * GoogleCloudPlatform/kubeflow-distribution#4 instructions for ACM
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
This change is |
Contributor
Author
|
/assign @Bobgy |
Contributor
|
/lgtm |
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
reviewed
Aug 3, 2020
| @@ -0,0 +1,20 @@ | |||
| # Define a transform to remove namespace from cluster scoped resources | |||
Contributor
There was a problem hiding this comment.
Do we need this because of a bug in kustomize (cannot know CRD scope)?
Can we link related issue in comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to produce YAMLs that are compatible with ACM related to
[ACM] Create a kustomize function to remove namespace from cluster scoped CRs GoogleCloudPlatform/kubeflow-distribution#27 kustomize function to remove namespace
Add instructions for deploying with ConfigSync/ACM GoogleCloudPlatform/kubeflow-distribution#4 instructions for ACM