Fix management blueprint kptfile and stop using namespace mode for CNRM.#1432
Merged
Conversation
* The management blueprint should have its own KptFile
* Prior to this PR there was only a KptFile at gcp/
* This doesn't work because for the management cluster we
only pull the package gcp/v2/management
* Related to GoogleCloudPlatform/kubeflow-distribution#102
* Related to GoogleCloudPlatform/kubeflow-distribution#93
* For CNRM Switch to workload identity and stop using namespace mode for CNRM; GoogleCloudPlatform/kubeflow-distribution#13
* Using namespace mode is just extra complexity because we have to install
a separate copy of the CNRM controller for every project.
* The only reason to do really do that is if you want to use different
GCP service accounts to manage different projects. Typically that's
not what we do.
* With workload identity we have 1 namespace per project but they
all use the same GCP SA so the GCP sa can just be authorized to
access multiple projects or a folder as needed.
* Update the resources to the v1beta1 spec for use with AnthosCLI
* It looks like anthoscli requires a NodePool resource
* With the v1beta1 specs we need to add the annotation gke.cluster.io = "bootstrap://" so that anthoscli is able to probably group the resources.
* Move cnrm-install iam and services into kustomize packages
* This way we can hydrate them like we do other manifests
* Fix the setters and substitutions for CNRM to make them unique per name
* This way we could potentially have multiple management clusters per project
which if nothing else will be useful for testing.
Contributor
Contributor
Author
|
/assign @Bobgy |
added 3 commits
July 29, 2020 07:40
…the workload identity servers.
Contributor
|
/lgtm |
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jul 31, 2020
…stop using namespace #1437: Fix cloudresourcemanager service; missing ApiVersion. Cherry pick of #1432 #1437 on v1.1-branch. #1432: Fix management blueprint kptfile and stop using namespace #1437: Fix cloudresourcemanager service; missing ApiVersion. (#1439) * Fix management blueprint kptfile and stop using namespace mode for CNRM. * The management blueprint should have its own KptFile * Prior to this PR there was only a KptFile at gcp/ * This doesn't work because for the management cluster we only pull the package gcp/v2/management * Related to GoogleCloudPlatform/kubeflow-distribution#102 * Related to GoogleCloudPlatform/kubeflow-distribution#93 * For CNRM Switch to workload identity and stop using namespace mode for CNRM; GoogleCloudPlatform/kubeflow-distribution#13 * Using namespace mode is just extra complexity because we have to install a separate copy of the CNRM controller for every project. * The only reason to do really do that is if you want to use different GCP service accounts to manage different projects. Typically that's not what we do. * With workload identity we have 1 namespace per project but they all use the same GCP SA so the GCP sa can just be authorized to access multiple projects or a folder as needed. * Update the resources to the v1beta1 spec for use with AnthosCLI * It looks like anthoscli requires a NodePool resource * With the v1beta1 specs we need to add the annotation gke.cluster.io = "bootstrap://" so that anthoscli is able to probably group the resources. * Move cnrm-install iam and services into kustomize packages * This way we can hydrate them like we do other manifests * Fix the setters and substitutions for CNRM to make them unique per name * This way we could potentially have multiple management clusters per project which if nothing else will be useful for testing. * Add workload identity pool to the management cluster. * Management nodepool should set workloadMetadataConfig so that we run the workload identity servers. * Fix. * Fix cloudresourcemanager service; missing ApiVersion. Related to: GoogleCloudPlatform/kubeflow-distribution#102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The management blueprint should have its own KptFile
only pull the package gcp/v2/management
Related to Fix the management blueprint GoogleCloudPlatform/kubeflow-distribution#102
Related to Split/Refactor gcp manifests into separate kpt packages GoogleCloudPlatform/kubeflow-distribution#93
For CNRM Switch to workload identity and stop using namespace mode for CNRM; Management cluster should not use CNRM in namespaced mode GoogleCloudPlatform/kubeflow-distribution#13
a separate copy of the CNRM controller for every project.
GCP service accounts to manage different projects. Typically that's
not what we do.
all use the same GCP SA so the GCP sa can just be authorized to
access multiple projects or a folder as needed.
Update the resources to the v1beta1 spec for use with AnthosCLI
Move cnrm-install iam and services into kustomize packages
Fix the setters and substitutions for CNRM to make them unique per name
which if nothing else will be useful for testing.