knative shouldn't be part of GCP stack kustomization#1381
Merged
Conversation
* related to GoogleCloudPlatform/kubeflow-distribution#74 * knative needs to be installed in its own namespace so we don't want to make it part of the kubeflow namespace kustomization package * We will have to install it separately in the blueprint.
Contributor
|
This change is |
Contributor
Author
|
/assign @Bobgy |
Contributor
|
/lgtm |
Contributor
Author
|
/approve @Bobgy Please try to do "/approve" in addition to lgtm so that PRs can be merged if you have approval rights. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
I see, will do so next time. |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jul 21, 2020
…#1381: knative shouldn't be part of GCP stack kustomization Cherry pick of #1376 #1381 on v1.1-branch. #1376: Add knative and kfserving to GCP stack #1381: knative shouldn't be part of GCP stack kustomization (#1385) * Add knative and kfserving to GCP stack * Related to: GoogleCloudPlatform/kubeflow-distribution#74 Fix common labels for knative and kfserving. * There were typos and they were including labels that by convention we currently don't want in common labels. * knative shouldn't be part of GCP stack kustomization * related to GoogleCloudPlatform/kubeflow-distribution#74 * knative needs to be installed in its own namespace so we don't want to make it part of the kubeflow namespace kustomization package * We will have to install it separately in the blueprint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to knative and kfserving is missing from GCP Blueprint GoogleCloudPlatform/kubeflow-distribution#74
knative needs to be installed in its own namespace so we don't want
to make it part of the kubeflow namespace kustomization package
We will have to install it separately in the blueprint.