Add missing finalizers for Katib experiment#1324
Merged
k8s-ci-robot merged 2 commits intoJun 30, 2020
Merged
Conversation
Contributor
|
This change is |
vpavlin
force-pushed
the
kf-upstream/openshift/katib
branch
from
4a1ef64 to
829c570
Compare
Member
|
@vpavlin Thank you for adding this. |
Member
Author
|
No, not really, this can be merged right away. I'll work on the PR for katib repo today |
andreyvelich
left a comment
andreyvelich
left a comment
Member
There was a problem hiding this comment.
/lgtm
/cc @gaocegege @johnugeorge
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, krishnadurai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #1323
This is necessary for being able to run Katib on OpenShift
Description of your changes:
Adding resource/finalizers to the Role
Checklist:
cd manifests/testsmake generate-changed-onlymake test