Add Katib CRD to components

[andreyvelich]

I added Katib CRDs to components, see discussion: #1124 (comment).

Also, I added commonLabels to components/katib-db-manager and components/katib-db-mysql and I removed commonLabels from installs/katib-standalone since it is not required.

@jlewi What do you think about Katib manifests v3 version? katib/installs and katib/components satisfies the V3 manifests rules.
I can delete current v3 manifests and make installs and components under v3 folder.

/assign @jlewi @gaocegege @johnugeorge

Checklist:

• Unit tests have been rebuilt:
  1. cd manifests/tests
  2. make generate-changed-only
  3. make test

[kubeflow-bot]

This change is 

[gaocegege]

/lgtm

I am not familiar with kustomize, thus prefer another review from kustomize experts.

[jlewi]

Is this the right name? Did you mean to call everything katib-controller even if its a db?

[andreyvelich]

Currently, it works like this.
We have one Application: https://github.com/kubeflow/manifests/blob/master/katib/katib-controller/overlays/application/application.yaml, for katib-controller, katib-db-manager and katib-mysql with this label (https://github.com/kubeflow/manifests/blob/master/katib/katib-controller/overlays/application/kustomization.yaml#L4).
If we want to make unique label for each component, do we need to create individual application for them?

[jlewi]

I can delete current v3 manifests and make installs and components under v3 folder

I didn't quite understand this. What are you proposing?

[andreyvelich]

I can delete current v3 manifests and make installs and components under v3 folder

I didn't quite understand this. What are you proposing?

I mean, we created Katib V3 manifest for katib-controller folder (https://github.com/kubeflow/manifests/tree/master/katib/katib-controller/v3) and katib-crds folder (https://github.com/kubeflow/manifests/tree/master/katib/katib-crds/v3).

After we migrated to folder structure katib/components and katib/installs these folders (katib/katib-controller and katib/katib-crds) are legacy (but we still use them in kfdef manifests).

In the new V3 version, I think we can use this new structure with components and installs for Katib.
So we can remove V3 version that related to old folders.

And I am asking do we need to point that new folder structure is related to V3 or it is not necessary?

[jlewi]

In the new V3 version, I think we can use this new structure with components and installs for Katib.
So we can remove V3 version that related to old folders.
Sounds good to me.

And I am asking do we need to point that new folder structure is related to V3 or it is not necessary?

I may not have understood what you are saying here. I think using the new folder structure is fine. You don't need to call it V3 .

/lgtm
/approve

/hold
In case you want to do the additional cleanup in this PR; otherwise you can remove the hold and submit as is.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• katib/OWNERS [jlewi]
• tests/OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andreyvelich]

In the new V3 version, I think we can use this new structure with components and installs for Katib.
So we can remove V3 version that related to old folders.
Sounds good to me.

And I am asking do we need to point that new folder structure is related to V3 or it is not necessary?

I may not have understood what you are saying here. I think using the new folder structure is fine. You don't need to call it V3 .

/lgtm
/approve

/hold
In case you want to do the additional cleanup in this PR; otherwise you can remove the hold and submit as is.

Thanks! I will submit another PR to remove old v3 folders.

[andreyvelich]

/hold cancel