Skip to content

Adding groups support in shared components crud-web-apps/common/backend#7084

Closed
axel7083 wants to merge 2 commits into
kubeflow:masterfrom
axel7083:crud-web-apps-groups-support
Closed

Adding groups support in shared components crud-web-apps/common/backend#7084
axel7083 wants to merge 2 commits into
kubeflow:masterfrom
axel7083:crud-web-apps-groups-support

Conversation

@axel7083

@axel7083 axel7083 commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

The oidc-authservice will add the "kubeflow-userid" and "kubeflow-groups" if properly configured with istio. The subject review just need to consume them to allow or not the user+groups.

See kubeflow/community-distribution#2910 for more detailed

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich

Copy link
Copy Markdown
Member

Thank you for this contribution!
We migrated the Kubeflow Notebooks code to the new GitHub repository: https://github.com/kubeflow/notebooks/tree/notebooks-v1
Please re-open PR there.
/close

@google-oss-prow google-oss-prow Bot closed this Sep 4, 2025
@google-oss-prow

Copy link
Copy Markdown

@andreyvelich: Closed this PR.

Details

In response to this:

Thank you for this contribution!
We migrated the Kubeflow Notebooks code to the new GitHub repository: https://github.com/kubeflow/notebooks/tree/notebooks-v1
Please re-open PR there.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants