This repository was archived by the owner on Aug 17, 2023. It is now read-only.
Cherry-pick of #439 and #440 to v1.2-branch#441
Merged
k8s-ci-robot merged 2 commits intoNov 11, 2020
Conversation
In anticipation of an update of the manifest knative version to v0.14.3, this PR removes a check for the autoscaler-hpa deployment which was removed.
Member
Author
|
/cc @PatrickXYS |
Member
|
/lgtm Thanks @pvaneck ! |
Member
This is because this PR is not yet cherry-picked #440 |
Member
Author
|
@PatrickXYS Want me to cherry-pick that in this PR? |
Member
pvaneck
changed the title
Remove autoscaler-hpa knative deployment check (#439) to v1.2-branch
Member
Author
|
@PatrickXYS I cherry-picked #440 here as well. |
Member
|
/lgtm Thanks @pvaneck ! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PatrickXYS, pvaneck The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Nov 11, 2020
Closed
Member
|
@pvaneck Feel free to unhold to merge the PR |
Member
Author
|
/unhold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks #439 and #440 in to v1.2-branch.