Skip to content

Clean up code for custom CRD#1355

Merged
k8s-ci-robot merged 3 commits into
kubeflow:masterfrom
andreyvelich:clean-up-custom-crd
Oct 26, 2020
Merged

Clean up code for custom CRD#1355
k8s-ci-robot merged 3 commits into
kubeflow:masterfrom
andreyvelich:clean-up-custom-crd

Conversation

@andreyvelich

@andreyvelich andreyvelich commented Oct 15, 2020

Copy link
Copy Markdown
Member

I removed redundant code and fixed tests for new custom CRD implementation.

As well, I added some default values for Job, PyTorchJob and TFJob to make examples easier for the first look, as we discussed before.

In particular, for Job:

  1. Set default SuccessCondition and FailureCondition.
    I didn't add PrimaryPodLabels to Job examples since each Job has only one pod replica. If PrimaryPodLabels is omitted, metrics collector injected to all created pods.

For Kubeflow Job (PytorchJob and TFJob).

  1. Set default SuccessCondition and FailureCondition.
  2. Set default PrimaryPodLabels.

I manually added PrimaryContainerName to all examples. I think it is very easy to understand and user can explicitly see which container will be wrapped by metrics collector.

I can't set default values if Trial Template is set in ConfigMap, since it requires k8s client. We can think about it later.

I left validation for Job, TFJob and PyTorchJob for now. @gaocegege @johnugeorge What do you think about it ?

I deleted job/v1beta1 since it is not used. Let's continue discussion here: #1320 how we should implement MutateJob.

/assign @gaocegege @johnugeorge

@kubeflow-bot

Copy link
Copy Markdown

This change is Reviewable

@gaocegege gaocegege left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich

Copy link
Copy Markdown
Member Author

/retest

@gaocegege gaocegege left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aws-kf-ci-bot

Copy link
Copy Markdown
Contributor

@andreyvelich: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-katib-presubmit 364df94 link /test kubeflow-katib-presubmit
kubeflow-katib-presubmit-e2e 364df94 link /test kubeflow-katib-presubmit-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4450611 into kubeflow:master Oct 26, 2020
@andreyvelich andreyvelich deleted the clean-up-custom-crd branch October 3, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants